-
Notifications
You must be signed in to change notification settings - Fork 0
Modernize the library #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the TypeScript library by replacing TSLint with ESLint, updating dependencies to current versions, and implementing modern TypeScript patterns including private fields, static factory methods, and improved type safety.
- Removes TSLint configuration and switches to ESLint with TypeScript support
- Updates all dependencies to modern versions (Jest 30, TypeScript 5.9, etc.)
- Refactors Result and Option classes to use private fields and static factory methods
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tslint.json | Completely removed TSLint configuration file |
| tsconfig.es.json | Enabled declaration generation for ES module build |
| tsconfig.cjs.json | Enabled declaration generation for CommonJS build |
| src/result.ts | Refactored to use private fields, static factory methods, and improved type safety |
| src/result.spec.ts | Updated tests to use explicit type parameters and modern formatting |
| src/options.ts | Refactored to use private fields, static factory methods, and improved type safety |
| src/options.spec.ts | Updated tests with modern formatting and explicit typing |
| src/iterable.ts | Converted to use private fields syntax |
| package.json | Updated all dependencies to modern versions and added new build/check scripts |
| eslint.config.ts | Added new ESLint configuration with TypeScript support |
| README.md | Updated code examples to match modern formatting standards |
# Conflicts: # package-lock.json # package.json # src/result.ts # tsconfig.cjs.json # tsconfig.es.json # tsconfig.json
Co-authored-by: Copilot <[email protected]>
No description provided.