Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On custom card wrong media-queries #33

Open
denvash opened this issue Oct 28, 2019 · 0 comments
Open

On custom card wrong media-queries #33

denvash opened this issue Oct 28, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@denvash
Copy link

denvash commented Oct 28, 2019

On providing a custom card, 768px is a "Golden Number" which may brake the component, in this case, the user should control the query and the default one need to be disabled.

localhost_8000_ (9)

Possible user's fix example:

const EventDetails = styled.div`
  ${mixins.boxShadowSmall}
  background-color: ${colors.backgroundDark};
  padding: 15px;
  @media (max-width: 768px) {
    display: none;
  }
`;

The user may not catch the bug on smaller devices, therefore, it is not expected behavior.

@steven-mercatante steven-mercatante added the enhancement New feature or request label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants