Skip to content

Commit 30855e8

Browse files
author
Steve Pfister
committed
[iOS] Skip test suites that take too long to build on helix
System.Text.RegularExpressions, Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests, and STJ source generator tests take too long to build on helix and time out before any tests are run. This is due in part to the amount of aot'd code, which ends up ballooning the app size to around 1GB. The solution is to enable aggressive trimming targets that are in tests.mobile.targets as this will shrink the app size considerably. Skipping these tests for now. Addresses dotnet#72834 Addresses dotnet#72836
1 parent 73374e8 commit 30855e8

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/libraries/tests.proj

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,11 +286,16 @@
286286
<!--
287287
Test apps that are too large and take too long to build
288288
Keep here until aggressive trimming targets can work on helix.
289+
290+
https://github.com/dotnet/runtime/issues/72834
291+
https://github.com/dotnet/runtime/issues/72836
289292
-->
290293
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\UnitTests\System.Text.RegularExpressions.Tests.csproj" />
294+
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.RegularExpressions\tests\FunctionalTests\System.Text.RegularExpressions.Tests.csproj" />
295+
<ProjectExclusions Include="$(MSBuildThisFileDirectory)Microsoft.Extensions.Logging.Abstractions\tests\Microsoft.Extensions.Logging.Generators.Tests\Microsoft.Extensions.Logging.Generators.Roslyn4.0.Tests.csproj" />
296+
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.Json\tests\System.Text.Json.SourceGeneration.Unit.Tests\System.Text.Json.SourceGeneration.Roslyn4.0.Unit.Tests.csproj" />
291297
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Text.Json\tests\System.Text.Json.SourceGeneration.Tests\System.Text.Json.SourceGeneration.Roslyn4.0.Tests.csproj" />
292298

293-
294299
<!-- Functional tests on devices have problems with return codes from mlaunch -->
295300
<ProjectExclusions Include="$(RepoRoot)\src\tests\FunctionalTests\$(TargetOS)\Device\**\*.Test.csproj" />
296301
</ItemGroup>

0 commit comments

Comments
 (0)