Open
Conversation
|
any chance someone has had time to take a look at this? |
|
@peacechen any chance you could take a look? |
peacechen
reviewed
Aug 2, 2024
peacechen
reviewed
Aug 2, 2024
peacechen
reviewed
Aug 2, 2024
Collaborator
|
Thanks @white-room for contributing this feature. Added a few comments. Please also resolve the conflicts in this PR. |
peacechen
reviewed
Aug 5, 2024
Collaborator
|
Thanks @andrewmcd1 for making those changes. |
peacechen
reviewed
Aug 6, 2024
peacechen
reviewed
Aug 6, 2024
Collaborator
|
@andrewmcd1 A number of other PRs have recently been merged and a release needs to be done soon. Can you take a look at my comments? Please test this in the sample app too. |
Author
|
@peacechen Is there any way I could get a review for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new prop,
renderDay, to enhance the customization capabilities ofreact-native-calendar-picker. With this addition, users can now provide a custom component to render each day in the calendar according to their specific requirements.Changes Introduced:
renderDay.Why is this change necessary?
The ability to customize the rendering of individual days in the calendar is a highly requested feature from our user community. By introducing the
renderDayprop, we empower users to tailor the calendar's appearance and behavior to suit their unique application needs.How to Use:
To utilize the new
renderDayprop:react-native-calendar-pickercomponent.renderDayprop, specifying how each day should be rendered.This enhancement enriches the versatility of
react-native-calendar-picker, empowering developers to create more tailored and engaging calendar experiences within their React Native applications.