phpstan (checkMissingIterableValueType true)

Author: stephanediondev

phpstan.neon

@@ -1,5 +1,4 @@
 parameters:
     checkGenericClassInNonGenericObjectType: false
-    checkMissingIterableValueType: false
     bootstrapFiles:
         - phpstan-constants.php

src/Command/GenerateFaviconsCommand.php

@@ -12,6 +12,9 @@
 #[AsCommand(name: 'app:generate-favicons')]
 class GenerateFaviconsCommand extends Command
 {
+    /**
+     * @var array<string> $colors
+     */
     private array $colors = [
         'red' => 'dc3545',
         'orange' => 'fd7e14',

src/Controller/AbstractAppController.php

@@ -49,6 +49,9 @@ public function setTranslator(TranslatorInterface $translator): void
         $this->translator = $translator;
     }
 
+    /**
+     * @param array<mixed> $parameters
+     */
     public function renderAbstract(Request $request, string $view, array $parameters = [], Response $response = null): Response
     {
         if (false === isset($parameters['firewall'])) {
@@ -137,6 +140,10 @@ public function renderAbstract(Request $request, string $view, array $parameters
         return $this->render($view, $parameters, $response);
     }
 
+    /**
+     * @param array<mixed> $entries
+     * @return array<mixed>
+     */
     private function populateMenu(array $entries): array
     {
         $menu = [];
@@ -156,6 +163,10 @@ private function populateMenu(array $entries): array
         return $menu;
     }
 
+    /**
+     * @param array<mixed> $a
+     * @param array<mixed> $b
+     */
     private function sortByName(array $a, array $b): int
     {
         return $a['name'] <=> $b['name'];

src/Controller/AppIndexDatabaseImportController.php

@@ -197,6 +197,9 @@ public function index(Request $request, string $index): Response
         ]);
     }
 
+    /**
+     * @param array<mixed> $fields
+     */
     private function getConnection(array $fields): PDO
     {
         $dbh = new PDO($fields['driver'].':host='.$fields['host'].';dbname='.$fields['dbname'], $fields['user'], $fields['password']);

src/Controller/AppSubscriptionsController.php

@@ -39,6 +39,9 @@ class AppSubscriptionsController extends AbstractAppController
 
     private string $senderAddress;
 
+    /**
+     * @var array<mixed> $clusterHealth
+     */
     private array $clusterHealth;
 
     public function __construct(AppSubscriptionManager $appSubscriptionManager, AppNotificationManager $appNotificationManager, AppUserManager $appUserManager, string $vapidPublicKey, string $vapidPrivateKey, string $mailerDsn, string $senderAddress)

src/Controller/ElasticsearchDanglingIndicesController.php

@@ -60,6 +60,10 @@ public function index(Request $request): Response
         ]);
     }
 
+    /**
+     * @param array<mixed> $a
+     * @param array<mixed> $b
+     */
     private function sortByCreationDate(array $a, array $b): int
     {
         return $b['creation_date_millis'] <=> $a['creation_date_millis'];

src/Controller/ElasticsearchIndexController.php

@@ -167,6 +167,10 @@ public function stats(Request $request): Response
         ]);
     }
 
+    /**
+     * @param array<mixed> $a
+     * @param array<mixed> $b
+     */
     private function sortByTotal(array $a, array $b): int
     {
         return $b['total'] <=> $a['total'];

src/Controller/ElasticsearchIndexGraveyardController.php

@@ -52,6 +52,10 @@ public function index(Request $request): Response
         ]);
     }
 
+    /**
+     * @param array<mixed> $a
+     * @param array<mixed> $b
+     */
     private function sortByDeleteDate(array $a, array $b): int
     {
         return $b['delete_date_in_millis'] <=> $a['delete_date_in_millis'];

src/Controller/ElasticsearchNodeController.php

@@ -28,6 +28,10 @@ public function __construct(ElasticsearchNodeManager $elasticsearchNodeManager)
         $this->elasticsearchNodeManager = $elasticsearchNodeManager;
     }
 
+    /**
+     * @param array<mixed> $nodes
+     * @return array<mixed>
+     */
     private function filter(array $nodes, FormInterface $form): array
     {
         return $this->elasticsearchNodeManager->filter($nodes, [
@@ -193,6 +197,10 @@ public function stats(Request $request): Response
         ]);
     }
 
+    /**
+     * @param array<mixed> $a
+     * @param array<mixed> $b
+     */
     private function sortByTotal(array $a, array $b): int
     {
         return $b['total'] <=> $a['total'];

src/Controller/ElasticsearchRepositoryController.php

@@ -210,6 +210,9 @@ public function verify(Request $request, string $repository): Response
         return $this->redirectToRoute('repositories_read', ['repository' => $repository->getName()]);
     }
 
+    /**
+     * @return array<mixed>
+     */
     private function getPaths(): array
     {
         $paths = [];