Skip to content

Commit 58e8d50

Browse files
stephanediondevstephanediondev
committed
phpstan (checkMissingIterableValueType true)
1 parent 49577e2 commit 58e8d50

File tree

72 files changed

+879
-4
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

72 files changed

+879
-4
lines changed

‎phpstan.neon

-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
parameters:
22
checkGenericClassInNonGenericObjectType: false
3-
checkMissingIterableValueType: false
43
bootstrapFiles:
54
- phpstan-constants.php

‎src/Command/GenerateFaviconsCommand.php

+3
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
#[AsCommand(name: 'app:generate-favicons')]
1313
class GenerateFaviconsCommand extends Command
1414
{
15+
/**
16+
* @var array<string> $colors
17+
*/
1518
private array $colors = [
1619
'red' => 'dc3545',
1720
'orange' => 'fd7e14',

‎src/Controller/AbstractAppController.php

+11
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,9 @@ public function setTranslator(TranslatorInterface $translator): void
4949
$this->translator = $translator;
5050
}
5151

52+
/**
53+
* @param array<mixed> $parameters
54+
*/
5255
public function renderAbstract(Request $request, string $view, array $parameters = [], Response $response = null): Response
5356
{
5457
if (false === isset($parameters['firewall'])) {
@@ -137,6 +140,10 @@ public function renderAbstract(Request $request, string $view, array $parameters
137140
return $this->render($view, $parameters, $response);
138141
}
139142

143+
/**
144+
* @param array<mixed> $entries
145+
* @return array<mixed>
146+
*/
140147
private function populateMenu(array $entries): array
141148
{
142149
$menu = [];
@@ -156,6 +163,10 @@ private function populateMenu(array $entries): array
156163
return $menu;
157164
}
158165

166+
/**
167+
* @param array<mixed> $a
168+
* @param array<mixed> $b
169+
*/
159170
private function sortByName(array $a, array $b): int
160171
{
161172
return $a['name'] <=> $b['name'];

‎src/Controller/AppIndexDatabaseImportController.php

+3
Original file line numberDiff line numberDiff line change
@@ -197,6 +197,9 @@ public function index(Request $request, string $index): Response
197197
]);
198198
}
199199

200+
/**
201+
* @param array<mixed> $fields
202+
*/
200203
private function getConnection(array $fields): PDO
201204
{
202205
$dbh = new PDO($fields['driver'].':host='.$fields['host'].';dbname='.$fields['dbname'], $fields['user'], $fields['password']);

‎src/Controller/AppSubscriptionsController.php

+3
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ class AppSubscriptionsController extends AbstractAppController
3939

4040
private string $senderAddress;
4141

42+
/**
43+
* @var array<mixed> $clusterHealth
44+
*/
4245
private array $clusterHealth;
4346

4447
public function __construct(AppSubscriptionManager $appSubscriptionManager, AppNotificationManager $appNotificationManager, AppUserManager $appUserManager, string $vapidPublicKey, string $vapidPrivateKey, string $mailerDsn, string $senderAddress)

‎src/Controller/ElasticsearchDanglingIndicesController.php

+4
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,10 @@ public function index(Request $request): Response
6060
]);
6161
}
6262

63+
/**
64+
* @param array<mixed> $a
65+
* @param array<mixed> $b
66+
*/
6367
private function sortByCreationDate(array $a, array $b): int
6468
{
6569
return $b['creation_date_millis'] <=> $a['creation_date_millis'];

‎src/Controller/ElasticsearchIndexController.php

+4
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,10 @@ public function stats(Request $request): Response
167167
]);
168168
}
169169

170+
/**
171+
* @param array<mixed> $a
172+
* @param array<mixed> $b
173+
*/
170174
private function sortByTotal(array $a, array $b): int
171175
{
172176
return $b['total'] <=> $a['total'];

‎src/Controller/ElasticsearchIndexGraveyardController.php

+4
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,10 @@ public function index(Request $request): Response
5252
]);
5353
}
5454

55+
/**
56+
* @param array<mixed> $a
57+
* @param array<mixed> $b
58+
*/
5559
private function sortByDeleteDate(array $a, array $b): int
5660
{
5761
return $b['delete_date_in_millis'] <=> $a['delete_date_in_millis'];

‎src/Controller/ElasticsearchNodeController.php

+8
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ public function __construct(ElasticsearchNodeManager $elasticsearchNodeManager)
2828
$this->elasticsearchNodeManager = $elasticsearchNodeManager;
2929
}
3030

31+
/**
32+
* @param array<mixed> $nodes
33+
* @return array<mixed>
34+
*/
3135
private function filter(array $nodes, FormInterface $form): array
3236
{
3337
return $this->elasticsearchNodeManager->filter($nodes, [
@@ -193,6 +197,10 @@ public function stats(Request $request): Response
193197
]);
194198
}
195199

200+
/**
201+
* @param array<mixed> $a
202+
* @param array<mixed> $b
203+
*/
196204
private function sortByTotal(array $a, array $b): int
197205
{
198206
return $b['total'] <=> $a['total'];

‎src/Controller/ElasticsearchRepositoryController.php

+3
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,9 @@ public function verify(Request $request, string $repository): Response
210210
return $this->redirectToRoute('repositories_read', ['repository' => $repository->getName()]);
211211
}
212212

213+
/**
214+
* @return array<mixed>
215+
*/
213216
private function getPaths(): array
214217
{
215218
$paths = [];

‎src/Controller/ElasticsearchShardController.php

+12
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ public function __construct(ElasticsearchShardManager $elasticsearchShardManager
3333
$this->elasticsearchNodeManager = $elasticsearchNodeManager;
3434
}
3535

36+
/**
37+
* @param array<mixed> $shards
38+
* @return array<mixed>
39+
*/
3640
private function filter(array $shards, FormInterface $form): array
3741
{
3842
return $this->elasticsearchShardManager->filter($shards, [
@@ -179,6 +183,10 @@ public function stats(Request $request): Response
179183
]);
180184
}
181185

186+
/**
187+
* @param array<mixed> $a
188+
* @param array<mixed> $b
189+
*/
182190
private function sortByTotal(array $a, array $b): int
183191
{
184192
return $b['total'] <=> $a['total'];
@@ -297,6 +305,10 @@ public function cancelAllocation(Request $request, string $index, string $number
297305
}
298306
}
299307

308+
/**
309+
* @param array<mixed> $json
310+
* @return array<mixed>
311+
*/
300312
private function clusterReroute(array $json): array
301313
{
302314
$callRequest = new CallRequestModel();

‎src/Controller/ElasticsearchSnapshotController.php

+4
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,10 @@ public function stats(Request $request): Response
133133
]);
134134
}
135135

136+
/**
137+
* @param array<mixed> $a
138+
* @param array<mixed> $b
139+
*/
136140
private function sortByTotal(array $a, array $b): int
137141
{
138142
return $b['total'] <=> $a['total'];

‎src/Controller/ElasticsearchTaskController.php

+4
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,10 @@ public function index(Request $request): Response
7575
]);
7676
}
7777

78+
/**
79+
* @param array<mixed> $a
80+
* @param array<mixed> $b
81+
*/
7882
private function sortByStartTime(array $a, array $b): int
7983
{
8084
return $b['start_time_in_millis'] <=> $a['start_time_in_millis'];

‎src/Form/Type/ElasticsearchEnrichPolicyType.php

+4
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,10 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
132132
});
133133
}
134134

135+
/**
136+
* @param array<mixed>|null $indices
137+
* @param array<mixed>|null $selected
138+
*/
135139
private function enrichFields(FormInterface $form, ?array $indices, ?array $selected): void
136140
{
137141
$choices = [];

‎src/Manager/AppManager.php

+9
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@ public function getVersion(): string
1515
return $this->version;
1616
}
1717

18+
/**
19+
* @return array<string>
20+
*/
1821
public function getIndices(): array
1922
{
2023
return [
@@ -26,6 +29,9 @@ public function getIndices(): array
2629
];
2730
}
2831

32+
/**
33+
* @return array<mixed>
34+
*/
2935
public function getSettings(string $index): array
3036
{
3137
return [
@@ -36,6 +42,9 @@ public function getSettings(string $index): array
3642
];
3743
}
3844

45+
/**
46+
* @return array<mixed>
47+
*/
3948
public function getMappings(string $index): array
4049
{
4150
switch ($index) {

‎src/Manager/AppNotificationManager.php

+20
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@
1616

1717
class AppNotificationManager extends AbstractAppManager
1818
{
19+
/**
20+
* @var array<mixed> $defaultInfo
21+
*/
1922
private array $defaultInfo = [
2023
'cluster_health' => null,
2124
'nodes' => null,
@@ -32,8 +35,14 @@ class AppNotificationManager extends AbstractAppManager
3235

3336
protected AppExtension $appExtension;
3437

38+
/**
39+
* @var array<mixed>|null $clusterHealth
40+
*/
3541
protected ?array $clusterHealth;
3642

43+
/**
44+
* @var array<mixed>|null $clusterSettings
45+
*/
3746
protected ?array $clusterSettings;
3847

3948
#[Required]
@@ -54,6 +63,9 @@ public function setAppExtension(AppExtension $appExtension): void
5463
$this->appExtension = $appExtension;
5564
}
5665

66+
/**
67+
* @return array<mixed>
68+
*/
5769
public function getAll(): array
5870
{
5971
$query['size'] = 1000;
@@ -102,6 +114,9 @@ public function send(AppNotificationModel $appNotificationModel): CallResponseMo
102114
return $this->callManager->call($callRequest);
103115
}
104116

117+
/**
118+
* @return array<mixed>
119+
*/
105120
public function generate(): array
106121
{
107122
try {
@@ -173,6 +188,11 @@ public function generate(): array
173188
}
174189
}
175190

191+
/**
192+
* @param array<mixed> $previousInfo
193+
* @param array<mixed> $lastInfo
194+
* @return array<mixed>
195+
*/
176196
public function compareInfo(array $previousInfo, array $lastInfo): array
177197
{
178198
$notifications = [];

‎src/Manager/AppRoleManager.php

+25
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ class AppRoleManager extends AbstractAppManager
1414
{
1515
private bool $permissionsDefined = false;
1616

17+
/**
18+
* @var array<mixed> $permissions
19+
*/
1720
private array $permissions = [];
1821

1922
public function getByName(string $name): ?AppRoleModel
@@ -42,6 +45,10 @@ public function getByName(string $name): ?AppRoleModel
4245
return $roleModel;
4346
}
4447

48+
/**
49+
* @param array<mixed>|null $query
50+
* @return array<mixed>
51+
*/
4552
public function getAll(?array $query = []): array
4653
{
4754
$query['size'] = 1000;
@@ -129,6 +136,9 @@ public function deletePermissionsByRoleName(string $name): CallResponseModel
129136
return $this->callManager->call($callRequest);
130137
}
131138

139+
/**
140+
* @return array<mixed>
141+
*/
132142
public function getPermissionsByUser(UserInterface $user): array
133143
{
134144
if (false === $this->permissionsDefined) {
@@ -150,6 +160,9 @@ public function getPermissionsByUser(UserInterface $user): array
150160
return $this->permissions;
151161
}
152162

163+
/**
164+
* @return array<mixed>
165+
*/
153166
public function getPermissionsByRole(string $role): array
154167
{
155168
$permissions = [];
@@ -200,6 +213,9 @@ public function setPermission(AppRoleModel $roleModel, string $module, string $p
200213
return $this->callManager->call($callRequest);
201214
}
202215

216+
/**
217+
* @return array<string>
218+
*/
203219
public function selectRoles(): array
204220
{
205221
$callRequest = new CallRequestModel();
@@ -221,6 +237,9 @@ public function selectRoles(): array
221237
return $roles;
222238
}
223239

240+
/**
241+
* @return array<mixed>
242+
*/
224243
public function getAttributes(): array
225244
{
226245
$attributes = $this->getAttributesRaw();
@@ -233,13 +252,19 @@ public function getAttributes(): array
233252
return $attributes;
234253
}
235254

255+
/**
256+
* @return array<mixed>
257+
*/
236258
public function getAttributesByModule(string $module): array
237259
{
238260
$attributes = $this->getAttributesRaw();
239261

240262
return $attributes[$module] ?? [];
241263
}
242264

265+
/**
266+
* @return array<mixed>
267+
*/
243268
public function getAttributesRaw(): array
244269
{
245270
$attributes = [

‎src/Manager/AppSubscriptionManager.php

+4
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@ public function getByEndpoint(string $endpoint): ?AppSubscriptionModel
6161
return $subscriptionModel;
6262
}
6363

64+
/**
65+
* @param array<mixed>|null $query
66+
* @return array<mixed>
67+
*/
6468
public function getAll(?array $query = []): array
6569
{
6670
$query['size'] = 1000;

‎src/Manager/AppUserManager.php

+4
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@ public function getByEmail(string $email): ?AppUserModel
6161
return $userModel;
6262
}
6363

64+
/**
65+
* @param array<mixed>|null $query
66+
* @return array<mixed>
67+
*/
6468
public function getAll(?array $query = []): array
6569
{
6670
$query['size'] = 1000;

0 commit comments

Comments
 (0)