[FEATURE] [internal] adds metrics for ingestion phases #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya1702
requested changes
Nov 3, 2025
internal/metrics/metrics.go
Outdated
| IncIngestionTransactionsProcessed(count int) | ||
| ObserveIngestionBatchSize(size int) | ||
| ObserveIngestionParticipantsCount(count int) | ||
| ObserveIngestionExistingAccountsCount(count int) |
Contributor
There was a problem hiding this comment.
I dont think this existing accounts metric makes sense for ingestion since we already track the accounts count using the IncActiveAccount and DecActiveAccount functions. We can remove this particular one from ingestion metric
aditya1702
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #340
What
Adds metric collection for the ingestion phase of processing
Why
To support the initial observability and testing of wallet backend
Known limitations
N/A
Changes to grafana dashboard will be provided once metrics are approved.
Issue that this PR addresses
#340
Checklist
PR Structure
allif the changes are broad or impact many packages.Thoroughness
Release