Resolve misc. linting issues

Author: Shaptic

cmd/stellar-rpc/internal/config/main.go

@@ -8,8 +8,6 @@ import (
 	"github.com/spf13/pflag"
 )
 
-const CaptiveCoreHTTPQueryPort = 11628
-
 // Config represents the configuration of a stellar-rpc server
 type Config struct {
 	ConfigPath string

cmd/stellar-rpc/internal/config/options.go

@@ -21,7 +21,8 @@ const (
 	SevenDayOfLedgers = OneDayOfLedgers * 7
 
 	defaultHTTPEndpoint         = "localhost:8000"
-	defaultCaptiveCoreQueryPort = 11628
+	defaultCaptiveCoreHTTPPort  = 11626 // regular queries like /info
+	defaultCaptiveCoreQueryPort = 11628 // high-performance bulk queries like /getledgerentry
 )
 
 // TODO: refactor and remove the linter exceptions
@@ -85,10 +86,9 @@ func (cfg *Config) options() Options {
 			Name:         "stellar-captive-core-http-port",
 			Usage:        "HTTP port for Captive Core to listen on (0 disables the HTTP server)",
 			ConfigKey:    &cfg.CaptiveCoreHTTPPort,
-			DefaultValue: uint(11626),
+			DefaultValue: uint(defaultCaptiveCoreQueryPort),
 		},
 		{
-
 			Name:         "stellar-captive-core-http-query-port",
 			Usage:        "HTTP port for Captive Core to listen on for high-performance queries like /getledgerentry (0 disables the HTTP server, must not conflict with CAPTIVE_CORE_HTTP_PORT)",
 			ConfigKey:    &cfg.CaptiveCoreHTTPQueryPort,

cmd/stellar-rpc/internal/daemon/interfaces/noOpDaemon.go

@@ -60,6 +60,6 @@ func (s noOpCoreClient) SubmitTransaction(context.Context, string) (*proto.TXRes
 	return &proto.TXResponse{Status: proto.PreflightStatusOk}, nil
 }
 
-func (s noOpCoreClient) GetLedgerEntries(ctx context.Context, ledgerSeq uint32, keys ...xdr.LedgerKey) (proto.GetLedgerEntryResponse, error) {
+func (s noOpCoreClient) GetLedgerEntries(context.Context, uint32, ...xdr.LedgerKey) (proto.GetLedgerEntryResponse, error) {
 	return proto.GetLedgerEntryResponse{}, nil
 }