Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop prefetching invalid entries #4253

Open
sisuresh opened this issue Mar 19, 2024 · 1 comment
Open

Stop prefetching invalid entries #4253

sisuresh opened this issue Mar 19, 2024 · 1 comment
Assignees
@ThomasBrady
Labels
bug

Comments

@sisuresh
Copy link
Contributor

The bulk load path ignores the invariants enforced on regular loads. For example, a trustline for the issuer cannot exist, so it cannot be loaded, but core still allows you to try prefetching that entry. We should stop prefetching invalid entries and enforce the invariants in bulk load as well.
This would allow us to add #4189 back in.
@anupsdf
Copy link
Contributor

anupsdf commented Apr 8, 2024

Related discussion in slack thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasBrady ThomasBrady

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sisuresh @ThomasBrady @anupsdf and others