Skip to content

Commit fd97e01

Browse files
committed
!fixup review fixes
1 parent 3917f1f commit fd97e01

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

src/herder/TxSetFrame.cpp

+6-1
Original file line numberDiff line numberDiff line change
@@ -1236,7 +1236,8 @@ TxSetPhaseFrame::Iterator::operator*() const
12361236
TxSetPhaseFrame::Iterator&
12371237
TxSetPhaseFrame::Iterator::operator++()
12381238
{
1239-
if (mStageIndex >= mStages.size())
1239+
if (mStageIndex >= mStages.size() ||
1240+
mClusterIndex >= mStages[mStageIndex].size())
12401241
{
12411242
throw std::runtime_error("TxPhase iterator out of bounds");
12421243
}
@@ -1663,6 +1664,10 @@ TxSetPhaseFrame::checkValidSoroban(
16631664

16641665
auto maxResources = sorobanConfig.maxLedgerResources();
16651666

1667+
// With parallel Soroban phase the instruction limit validation is more
1668+
// complex than just comparing the total instructions to the ledger-wide
1669+
// limit. Thus, we skip the instruction check for the parallel phase and
1670+
// do the proper check further below.
16661671
if (protocolVersionStartsFrom(lclHeader.ledgerVersion,
16671672
PARALLEL_SOROBAN_PHASE_PROTOCOL_VERSION))
16681673
{

0 commit comments

Comments
 (0)