Added openStream helper in Bucket

Author: SirTyson

src/bucket/Bucket.cpp

@@ -77,14 +77,21 @@ Bucket::Bucket()
 {
 }
 
+std::unique_ptr<XDRInputFileStream>
+Bucket::openStream()
+{
+    releaseAssertOrThrow(!mFilename.empty());
+    auto streamPtr = std::make_unique<XDRInputFileStream>();
+    streamPtr->open(mFilename.string());
+    return std::move(streamPtr);
+}
+
 XDRInputFileStream&
 Bucket::getIndexStream()
 {
     if (!mIndexStream)
     {
-        mIndexStream = std::make_unique<XDRInputFileStream>();
-        releaseAssertOrThrow(!mFilename.empty());
-        mIndexStream->open(mFilename.string());
+        mIndexStream = openStream();
     }
     return *mIndexStream;
 }
@@ -94,9 +101,7 @@ Bucket::getEvictionStream()
 {
     if (!mEvictionStream)
     {
-        mEvictionStream = std::make_unique<XDRInputFileStream>();
-        releaseAssertOrThrow(!mFilename.empty());
-        mEvictionStream->open(mFilename.string());
+        mEvictionStream = openStream();
     }
     return *mEvictionStream;
 }

src/bucket/Bucket.h

@@ -70,6 +70,8 @@ class Bucket : public std::enable_shared_from_this<Bucket>,
     std::optional<BucketEntry>
     getEntryAtOffset(LedgerKey const& k, std::streamoff pos, size_t pageSize);
 
+    std::unique_ptr<XDRInputFileStream> openStream();
+
     static std::string randomFileName(std::string const& tmpDir,
                                       std::string ext);