Make test reporter robust against odd callback order (this happens)

graydon · graydon · commit 6b9b5a05a027 · 2025-02-07T21:57:37.000-08:00
diff --git a/src/test/SimpleTestReporter.h b/src/test/SimpleTestReporter.h
@@ -57,7 +57,10 @@ struct SimpleTestReporter : public ConsoleReporter
         bool res = _assertionStats.assertionResult.isOk();
         if (!res)
         {
-            ConsoleReporter::assertionStarting(*mLastAssertInfo);
+            if (mLastAssertInfo)
+            {
+                ConsoleReporter::assertionStarting(*mLastAssertInfo);
+            }
             res = ConsoleReporter::assertionEnded(_assertionStats);
         }
         mLastAssertInfo.reset();

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,10 @@ struct SimpleTestReporter : public ConsoleReporter`
`57`	`57`	`bool res = _assertionStats.assertionResult.isOk();`
`58`	`58`	`if (!res)`
`59`	`59`	`{`
`60`		`- ConsoleReporter::assertionStarting(*mLastAssertInfo);`
	`60`	`+ if (mLastAssertInfo)`
	`61`	`+ {`
	`62`	`+ ConsoleReporter::assertionStarting(*mLastAssertInfo);`
	`63`	`+ }`
`61`	`64`	`res = ConsoleReporter::assertionEnded(_assertionStats);`
`62`	`65`	`}`
`63`	`66`	`mLastAssertInfo.reset();`