Formatted using clang-format-20

anupsdf · graydon · anupsdf · commit 47f9f1fea143 · 2025-11-21T00:29:21.000-08:00
Temporarily comment out restoring cached llvm-12 builds

Update Github CI to run on Ubuntu 24.04 with clang-20

i# temporarily switch to standard GHA runner since 16-core jammy runner does not have some packages

parent 691b19a983be2f3b561517714a9e01a854b4e19c
author anupsdf &lt;anup.pani@stellar.org&gt; 1763712854 -0800
committer anupsdf &lt;anup.pani@stellar.org&gt; 1763713191 -0800
gpgsig -----BEGIN PGP SIGNATURE-----

 iQIzBAABCAAdFiEEsVPy9QBRCNnRvXpUEUPOcP21IwMFAmkgIKcACgkQEUPOcP21
 IwPyaxAAu6VD+bcJrh3ecbfseNDO9JPaH62uoVKTJn7yOX/D/nIV1XnWflvJE/c8
 ulgn9nvGWVCg8qCLQ5whxuPubVJQwvhKHzBvj7tBMw2iPAV0BOkgsSB+m3wzYxXl
 0fiDhWtDw21ju+d3RMu+vrag8AXJLyfOpXLF3oRRO2uzB/XKpPL7UDdE63/d7sW1
 qgsY3HIhPQ9DLkEOxYw0lVZPAl+WHNFm2BU+Af7XFI29y/e/L1HYTQ6700FUJVUp
 AFzqWmk6zZwHOeWk3ZpRmm20beLvHfx2nJGYFe0HnfJTay1VWKW8tH3mHxpzY/lu
 wblB0B+SIrpOLxHJcQrxRCdQ9xyujcCcq4Pv6Y8/X8Xzn86IH9BHOd/V6CEdwrWq
 JxWNuyB4XWIbDvCwKExFdxmB4Fe0XBQX5Nwnbu3/II78h5jt1f9M1dQ9Y9N58xIV
 2Ha9dRPYA4dKvblyrIVM7mstlASWx+XzvC80aGx22EjlgxY0uP7/rStm1uqqrIT6
 23jY53jx9dySMxAKaQ1Y+Nr+zB1Ig2G5IprNGh4VW/S/mj5K/4aNi68VMLVq7p5Z
 hie3RGA+lT8kaCIkbcwvG9zwr5tzXjyf/g1YgG41FOR0R0wqXuLgzNlAtT6r01zq
 DA9kC93QgekmntExsK4AAviJHWW2xrodzkj1zEXufoz+j/0y/7c=
 =DES8
 -----END PGP SIGNATURE-----

Co-authored-by: Graydon Hoare &lt;graydon@pobox.com&gt;

Update INSTALL.md

Co-authored-by: Graydon Hoare &lt;graydon@pobox.com&gt;
diff --git a/INSTALL.md b/INSTALL.md
@@ -82,11 +82,9 @@ We also include a script in the repository `install-rust.sh` that downloads and
 ### Ubuntu
 
 #### Ubuntu 22.04
-You can install the [test toolchain](#adding-the-test-toolchain) to build and run stellar-core with the latest version of the llvm toolchain.
+If you build Ubuntu with clang you have to use `libc++` instead of `libstdc++` when compiling.
 
-Alternatively, if you want to just depend on stock Ubuntu, you will have to build with clang *and* have to use `libc++` instead of `libstdc++` when compiling.
-
-Ubuntu 22.04 has clang-20 available but you have add LLVM apt repository dependency,
+Stock Ubuntu doesn't come packaged with clang-20, so you have add LLVM apt repository dependency for it,
 ```zsh
 sudo wget -O /etc/apt/trusted.gpg.d/apt.llvm.org.asc https://apt.llvm.org/llvm-snapshot.gpg.key
 
@@ -96,7 +94,7 @@ deb-src http://apt.llvm.org/jammy/ llvm-toolchain-jammy-20 main
 EOF
 ```
 
-After that you can install clang-20,
+# install clang-20 toolchain
 ```zsh
 sudo apt-get update
 sudo apt-get -y install clang-20 llvm-20
@@ -105,14 +103,15 @@ sudo apt-get -y install clang-20 llvm-20
 After installing packages, head to [building with clang and libc++](#building-with-clang-and-libc).
 
 
-#### Adding the test toolchain (optional)
+#### Adding gcc-14 / g++-14 from PPA (optional)
 ```zsh
 # NOTE: newer version of the compilers are not
 #    provided by stock distributions
 #    and are provided by the /test toolchain
 sudo apt-get install software-properties-common
 sudo add-apt-repository ppa:ubuntu-toolchain-r/test
 sudo apt-get update
+sudo apt install gcc-14 g++-14
 ```
 
 #### Installing packages
@@ -152,7 +151,7 @@ sudo apt-get install libc++-20-dev libc++abi-20-dev libclang-rt-20-dev
 
 Note that installing libc++-20 via apt will uninstall all other libc++ versions.
 
-Additionally, some newer Linux distros no longer package clang-format-12, and newer clang-format versions are
+Additionally, some newer Linux distros no longer package clang-format-20, and newer clang-format versions are
 not backwards compatible. To build from source, you'll need to do the following:
 
 ```zsh
diff --git a/src/bucket/BucketApplicator.cpp b/src/bucket/BucketApplicator.cpp
@@ -57,7 +57,8 @@ BucketApplicator::BucketApplicator(Application& app,
     }
 }
 
-BucketApplicator::operator bool() const
+BucketApplicator::
+operator bool() const
 {
     // There is more work to do (i.e. (bool) *this == true) iff:
     // 1. The underlying bucket iterator is not EOF and
diff --git a/src/bucket/BucketListBase.cpp b/src/bucket/BucketListBase.cpp
@@ -335,7 +335,8 @@ BucketListDepth::operator=(uint32_t numLevels)
     return *this;
 }
 
-BucketListDepth::operator uint32_t() const
+BucketListDepth::
+operator uint32_t() const
 {
     return mNumLevels;
 }
diff --git a/src/catchup/LedgerApplyManager.h b/src/catchup/LedgerApplyManager.h
@@ -116,7 +116,7 @@ class LedgerApplyManager
 
     virtual CatchupMetrics const& getCatchupMetrics() = 0;
 
-    virtual ~LedgerApplyManager(){};
+    virtual ~LedgerApplyManager() {};
 
     virtual void historyArchiveStatesDownloaded(uint32_t num = 1) = 0;
     virtual void ledgersVerified(uint32_t num = 1) = 0;
diff --git a/src/herder/QuorumIntersectionChecker.h b/src/herder/QuorumIntersectionChecker.h
@@ -85,7 +85,7 @@ class QuorumIntersectionChecker
                            std::optional<stellar::Config> const&)> const&
             networkEnjoysQuorumIntersectionCB);
 
-    virtual ~QuorumIntersectionChecker(){};
+    virtual ~QuorumIntersectionChecker() {};
     virtual bool networkEnjoysQuorumIntersection() const = 0;
     virtual size_t getMaxQuorumsFound() const = 0;
     virtual std::pair<std::vector<NodeID>, std::vector<NodeID>>
diff --git a/src/herder/test/TxSetTests.cpp b/src/herder/test/TxSetTests.cpp
@@ -890,8 +890,7 @@ testGeneralizedTxSetXDRConversion(ProtocolVersion protocolVersion)
     }
     {
         INFO("built from transactions");
-        auto getLclHeader = [&]() -> auto const&
-        {
+        auto getLclHeader = [&]() -> auto const& {
             return app->getLedgerManager().getLastClosedLedgerHeader();
         };
         std::vector<TransactionFrameBasePtr> const txs =
diff --git a/src/history/HistoryManager.h b/src/history/HistoryManager.h
@@ -418,7 +418,7 @@ class HistoryManager
     virtual void setPublicationEnabled(bool enabled) = 0;
 #endif
 
-    virtual ~HistoryManager(){};
+    virtual ~HistoryManager() {};
 
     virtual Config const& getConfig() const = 0;
 };
diff --git a/src/ledger/LedgerStateSnapshot.cpp b/src/ledger/LedgerStateSnapshot.cpp
@@ -50,7 +50,8 @@ LedgerEntryWrapper::current() const
     }
 }
 
-LedgerEntryWrapper::operator bool() const
+LedgerEntryWrapper::
+operator bool() const
 {
     switch (mEntry.index())
     {
diff --git a/src/ledger/LedgerTxn.cpp b/src/ledger/LedgerTxn.cpp
@@ -375,7 +375,8 @@ EntryIterator::operator++()
     return *this;
 }
 
-EntryIterator::operator bool() const
+EntryIterator::
+operator bool() const
 {
     return !getImpl()->atEnd();
 }
@@ -3102,7 +3103,8 @@ LedgerTxnRoot::prepareNewObjects(size_t s)
     mImpl->prepareNewObjects(s);
 }
 
-void LedgerTxnRoot::Impl::prepareNewObjects(size_t)
+void
+LedgerTxnRoot::Impl::prepareNewObjects(size_t)
 {
 }
 
diff --git a/src/ledger/LedgerTxnEntry.cpp b/src/ledger/LedgerTxnEntry.cpp
@@ -106,7 +106,8 @@ LedgerTxnEntry::operator=(LedgerTxnEntry&& other)
     return *this;
 }
 
-LedgerTxnEntry::operator bool() const
+LedgerTxnEntry::
+operator bool() const
 {
     if (!mImpl.expired())
     {
@@ -317,7 +318,8 @@ ConstLedgerTxnEntry::operator=(ConstLedgerTxnEntry&& other)
     return *this;
 }
 
-ConstLedgerTxnEntry::operator bool() const
+ConstLedgerTxnEntry::
+operator bool() const
 {
     if (!mImpl.expired())
     {
diff --git a/src/ledger/LedgerTxnHeader.cpp b/src/ledger/LedgerTxnHeader.cpp
@@ -77,7 +77,8 @@ LedgerTxnHeader::operator=(LedgerTxnHeader&& other)
     return *this;
 }
 
-LedgerTxnHeader::operator bool() const
+LedgerTxnHeader::
+operator bool() const
 {
     return !mImpl.expired();
 }
diff --git a/src/ledger/TrustLineWrapper.cpp b/src/ledger/TrustLineWrapper.cpp
@@ -111,7 +111,8 @@ TrustLineWrapper::TrustLineWrapper(LedgerTxnEntry&& entry)
     }
 }
 
-TrustLineWrapper::operator bool() const
+TrustLineWrapper::
+operator bool() const
 {
     return (bool)mImpl && (bool)(*mImpl);
 }
@@ -206,7 +207,8 @@ TrustLineWrapper::NonIssuerImpl::NonIssuerImpl(LedgerTxnEntry&& entry)
 {
 }
 
-TrustLineWrapper::NonIssuerImpl::operator bool() const
+TrustLineWrapper::NonIssuerImpl::
+operator bool() const
 {
     return (bool)mEntry;
 }
@@ -291,7 +293,8 @@ TrustLineWrapper::IssuerImpl::IssuerImpl(AccountID const& accountID,
 {
 }
 
-TrustLineWrapper::IssuerImpl::operator bool() const
+TrustLineWrapper::IssuerImpl::
+operator bool() const
 {
     return true;
 }
@@ -440,7 +443,8 @@ ConstTrustLineWrapper::ConstTrustLineWrapper(ConstLedgerTxnEntry&& entry)
     }
 }
 
-ConstTrustLineWrapper::operator bool() const
+ConstTrustLineWrapper::
+operator bool() const
 {
     return (bool)mImpl && (bool)(*mImpl);
 }
@@ -491,7 +495,8 @@ ConstTrustLineWrapper::NonIssuerImpl::NonIssuerImpl(ConstLedgerTxnEntry&& entry)
 {
 }
 
-ConstTrustLineWrapper::NonIssuerImpl::operator bool() const
+ConstTrustLineWrapper::NonIssuerImpl::
+operator bool() const
 {
     return (bool)mEntry;
 }
@@ -529,7 +534,8 @@ ConstTrustLineWrapper::NonIssuerImpl::getMaxAmountReceive(
 }
 
 // Implementation of ConstTrustLineWrapper::IssuerImpl ------------------------
-ConstTrustLineWrapper::IssuerImpl::operator bool() const
+ConstTrustLineWrapper::IssuerImpl::
+operator bool() const
 {
     return true;
 }
diff --git a/src/ledger/TrustLineWrapper.h b/src/ledger/TrustLineWrapper.h
@@ -69,7 +69,7 @@ class TrustLineWrapper::AbstractImpl
     AbstractImpl(AbstractImpl&&) = delete;
     AbstractImpl& operator=(AbstractImpl&&) = delete;
 
-    virtual ~AbstractImpl(){};
+    virtual ~AbstractImpl() {};
 
     virtual operator bool() const = 0;
 
@@ -142,7 +142,7 @@ class ConstTrustLineWrapper::AbstractImpl
     AbstractImpl(AbstractImpl&&) = delete;
     AbstractImpl& operator=(AbstractImpl&&) = delete;
 
-    virtual ~AbstractImpl(){};
+    virtual ~AbstractImpl() {};
 
     virtual operator bool() const = 0;
 
diff --git a/src/ledger/test/InMemoryLedgerTxnRoot.cpp b/src/ledger/test/InMemoryLedgerTxnRoot.cpp
@@ -145,7 +145,8 @@ InMemoryLedgerTxnRoot::prefetch(UnorderedSet<LedgerKey> const&)
     return 0;
 }
 
-void InMemoryLedgerTxnRoot::prepareNewObjects(size_t)
+void
+InMemoryLedgerTxnRoot::prepareNewObjects(size_t)
 {
 }
 
diff --git a/src/main/Application.h b/src/main/Application.h
@@ -179,7 +179,7 @@ class Application
         APPLY
     };
 
-    virtual ~Application(){};
+    virtual ~Application() {};
 
     virtual void initialize(bool createNewDB, bool forceRebuild) = 0;
 
diff --git a/src/overlay/test/ItemFetcherTests.cpp b/src/overlay/test/ItemFetcherTests.cpp
@@ -28,7 +28,7 @@ namespace
 class HerderStub : public HerderImpl
 {
   public:
-    HerderStub(Application& app) : HerderImpl(app){};
+    HerderStub(Application& app) : HerderImpl(app) {};
 
     std::vector<int> received;
 
diff --git a/src/overlay/test/SurveyManagerTests.cpp b/src/overlay/test/SurveyManagerTests.cpp
@@ -359,8 +359,7 @@ TEST_CASE("topology survey", "[overlay][survey][topology]")
         // A is running survey
         startSurveyReportingFrom(simulation, keyList[A]);
 
-        auto getSM = [&](NodeID const& key) -> auto&
-        {
+        auto getSM = [&](NodeID const& key) -> auto& {
             return simulation->getNode(key)
                 ->getOverlayManager()
                 .getSurveyManager();
diff --git a/src/process/PosixSpawnFileActions.cpp b/src/process/PosixSpawnFileActions.cpp
@@ -59,7 +59,8 @@ PosixSpawnFileActions::addOpen(int fildes, std::string const& fileName,
     }
 }
 
-PosixSpawnFileActions::operator posix_spawn_file_actions_t*()
+PosixSpawnFileActions::
+operator posix_spawn_file_actions_t*()
 {
     return mInitialized ? &mFileActions : nullptr;
 }
diff --git a/src/test/FuzzerImpl.cpp b/src/test/FuzzerImpl.cpp
@@ -911,7 +911,7 @@ class FuzzTransactionFrame : public TransactionFrame
     FuzzTransactionFrame(Hash const& networkID,
                          TransactionEnvelope const& envelope)
         : TransactionFrame(networkID, envelope)
-        , mTxResult(MutableTransactionResult::createSuccess(*this, 0)){};
+        , mTxResult(MutableTransactionResult::createSuccess(*this, 0)) {};
 
     void
     attemptApplication(Application& app, AbstractLedgerTxn& ltx)
diff --git a/src/transactions/LiquidityPoolWithdrawOpFrame.cpp b/src/transactions/LiquidityPoolWithdrawOpFrame.cpp
@@ -56,8 +56,7 @@ LiquidityPoolWithdrawOpFrame::doApply(AppConnector& app, AbstractLedgerTxn& ltx,
 
     // use a lambda so we don't hold a reference to the internals of
     // LiquidityPoolEntry
-    auto constantProduct = [&]() -> auto&
-    {
+    auto constantProduct = [&]() -> auto& {
         return poolEntry.current().data.liquidityPool().body.constantProduct();
     };
 
diff --git a/src/transactions/OfferExchange.cpp b/src/transactions/OfferExchange.cpp
@@ -1419,8 +1419,7 @@ exchangeWithPool(AbstractLedgerTxn& ltxOuter, Asset const& toPoolAsset,
         return false;
     }
 
-    auto cp = [&lp]() -> auto&
-    {
+    auto cp = [&lp]() -> auto& {
         return lp.current().data.liquidityPool().body.constantProduct();
     };
 
diff --git a/src/transactions/TransactionUtils.cpp b/src/transactions/TransactionUtils.cpp
@@ -1672,8 +1672,7 @@ removeOffersAndPoolShareTrustLines(AbstractLedgerTxn& ltx,
         auto pool = loadLiquidityPool(ltxInner, poolID);
         // use a lambda so we don't hold a reference to the
         // LiquidityPoolEntry
-        auto constantProduct = [&]() -> auto&
-        {
+        auto constantProduct = [&]() -> auto& {
             return pool.current().data.liquidityPool().body.constantProduct();
         };
 
diff --git a/src/transactions/test/OfferTests.cpp b/src/transactions/test/OfferTests.cpp
diff --git a/src/util/LogSlowExecution.cpp b/src/util/LogSlowExecution.cpp
diff --git a/src/util/SpdlogTweaks.h b/src/util/SpdlogTweaks.h
diff --git a/src/util/Timer.h b/src/util/Timer.h
diff --git a/src/work/test/WorkTests.cpp b/src/work/test/WorkTests.cpp

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,8 @@ BucketApplicator::BucketApplicator(Application& app,`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`
`60`		`-BucketApplicator::operator bool() const`
	`60`	`+BucketApplicator::`
	`61`	`+operator bool() const`
`61`	`62`	`{`
`62`	`63`	`// There is more work to do (i.e. (bool) *this == true) iff:`
`63`	`64`	`// 1. The underlying bucket iterator is not EOF and`
Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,8 @@ BucketListDepth::operator=(uint32_t numLevels)`
`335`	`335`	`return *this;`
`336`	`336`	`}`
`337`	`337`
`338`		`-BucketListDepth::operator uint32_t() const`
	`338`	`+BucketListDepth::`
	`339`	`+operator uint32_t() const`
`339`	`340`	`{`
`340`	`341`	`return mNumLevels;`
`341`	`342`	`}`
Original file line number	Diff line number	Diff line change
`@@ -890,8 +890,7 @@ testGeneralizedTxSetXDRConversion(ProtocolVersion protocolVersion)`
`890`	`890`	`}`
`891`	`891`	`{`
`892`	`892`	`INFO("built from transactions");`
`893`		`- auto getLclHeader = [&]() -> auto const&`
`894`		`- {`
	`893`	`+ auto getLclHeader = [&]() -> auto const& {`
`895`	`894`	`return app->getLedgerManager().getLastClosedLedgerHeader();`
`896`	`895`	`};`
`897`	`896`	`std::vector<TransactionFrameBasePtr> const txs =`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,8 @@ LedgerEntryWrapper::current() const`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`
`53`		`-LedgerEntryWrapper::operator bool() const`
	`53`	`+LedgerEntryWrapper::`
	`54`	`+operator bool() const`
`54`	`55`	`{`
`55`	`56`	`switch (mEntry.index())`
`56`	`57`	`{`
Original file line number	Diff line number	Diff line change
`@@ -375,7 +375,8 @@ EntryIterator::operator++()`
`375`	`375`	`return *this;`
`376`	`376`	`}`
`377`	`377`
`378`		`-EntryIterator::operator bool() const`
	`378`	`+EntryIterator::`
	`379`	`+operator bool() const`
`379`	`380`	`{`
`380`	`381`	`return !getImpl()->atEnd();`
`381`	`382`	`}`
`@@ -3102,7 +3103,8 @@ LedgerTxnRoot::prepareNewObjects(size_t s)`
`3102`	`3103`	`mImpl->prepareNewObjects(s);`
`3103`	`3104`	`}`
`3104`	`3105`
`3105`		`-void LedgerTxnRoot::Impl::prepareNewObjects(size_t)`
	`3106`	`+void`
	`3107`	`+LedgerTxnRoot::Impl::prepareNewObjects(size_t)`
`3106`	`3108`	`{`
`3107`	`3109`	`}`
`3108`	`3110`
Original file line number	Diff line number	Diff line change
`@@ -106,7 +106,8 @@ LedgerTxnEntry::operator=(LedgerTxnEntry&& other)`
`106`	`106`	`return *this;`
`107`	`107`	`}`
`108`	`108`
`109`		`-LedgerTxnEntry::operator bool() const`
	`109`	`+LedgerTxnEntry::`
	`110`	`+operator bool() const`
`110`	`111`	`{`
`111`	`112`	`if (!mImpl.expired())`
`112`	`113`	`{`
`@@ -317,7 +318,8 @@ ConstLedgerTxnEntry::operator=(ConstLedgerTxnEntry&& other)`
`317`	`318`	`return *this;`
`318`	`319`	`}`
`319`	`320`
`320`		`-ConstLedgerTxnEntry::operator bool() const`
	`321`	`+ConstLedgerTxnEntry::`
	`322`	`+operator bool() const`
`321`	`323`	`{`
`322`	`324`	`if (!mImpl.expired())`
`323`	`325`	`{`