Don't scan protocol 19 buckets for eviction

SirTyson · SirTyson · commit 27d30f400c3e · 2024-01-29T17:56:56.000-08:00
diff --git a/src/bucket/Bucket.cpp b/src/bucket/Bucket.cpp
@@ -845,9 +845,11 @@ Bucket::scanForEviction(AbstractLedgerTxn& ltx, EvictionIterator& iter,
                         std::optional<EvictionMetrics>& metrics)
 {
     ZoneScoped;
-    if (isEmpty())
+    if (isEmpty() ||
+        protocolVersionIsBefore(getBucketVersion(shared_from_this()),
+                                ProtocolVersion::V_20))
     {
-        // EOF
+        // EOF, skip to next bucket
         return false;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -845,9 +845,11 @@ Bucket::scanForEviction(AbstractLedgerTxn& ltx, EvictionIterator& iter,`
`845`	`845`	`std::optional<EvictionMetrics>& metrics)`
`846`	`846`	`{`
`847`	`847`	`ZoneScoped;`
`848`		`- if (isEmpty())`
	`848`	`+ if (isEmpty() \|\|`
	`849`	`+ protocolVersionIsBefore(getBucketVersion(shared_from_this()),`
	`850`	`+ ProtocolVersion::V_20))`
`849`	`851`	`{`
`850`		`- // EOF`
	`852`	`+ // EOF, skip to next bucket`
`851`	`853`	`return false;`
`852`	`854`	`}`
`853`	`855`