feat(connector): add ClientId #6973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds ClientID support to the connector system, enabling isolated state management per DApp client (Dapp browser, Chrome extension, wallet-connect).
Key changes include:
- Database migration to add
client_idcolumn with composite PRIMARY KEY (url, client_id) - API updates to include
ClientIDfield in relevant structs and function signatures - Backward compatibility support for existing clients using empty string as default client ID
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| walletdatabase/migrations/sql/1759312232_add_client_id_to_connector_dapps.up.sql | Migration script to add client_id column and composite primary key |
| signal/events_connector.go | Added ClientID field to ConnectorDApp struct |
| services/connector/database/persistence.go | Updated database operations to use URL+ClientID composite key |
| services/connector/database/persistence_test.go | Added comprehensive tests for multi-client scenarios |
| services/connector/commands/*.go | Updated all command handlers to use ClientID in database operations |
| services/connector/api.go | Modified API methods to accept and use ClientID parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Jenkins BuildsClick to see older builds (60)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6973 +/- ##
===========================================
- Coverage 59.69% 59.65% -0.04%
===========================================
Files 804 805 +1
Lines 114143 114177 +34
===========================================
- Hits 68137 68117 -20
- Misses 39019 39046 +27
- Partials 6987 7014 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
igor-sirotin
reviewed
Oct 2, 2025
friofry
force-pushed
the
ab/issue-6972-connector-client-id
branch
2 times, most recently
from
afae65c to
4b0b6d6
Compare
friofry
force-pushed
the
ab/issue-6972-connector-client-id
branch
2 times, most recently
from
5aae232 to
171db7e
Compare
alexjba
approved these changes
Oct 21, 2025
igor-sirotin
approved these changes
Oct 21, 2025
friofry
force-pushed
the
ab/issue-6972-connector-client-id
branch
from
171db7e to
07e9e68
Compare
friofry
force-pushed
the
ab/issue-6972-connector-client-id
branch
2 times, most recently
from
b75bfac to
b3304bb
Compare
* set clientId in ConnectorClient fixes #6972
friofry
force-pushed
the
ab/issue-6972-connector-client-id
branch
from
b3304bb to
970afcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6972
Allow isolated state management per dapp (Dapp browser, chrome extension, wallet-connect)
Database:
client_idcolumn with composite PRIMARY KEY (url, client_id). Existing records migrated with client_id = '' for backward compatibility.API:
ClientIDfield toRPCRequest,ConnectorDApp,DAppDefaultClientIDconstant for backward compatibility. Old clients(browser extension) automatically use empty string "".