fix: Disable privacy by default when syncing with older status-go versions

Fixing status-im/status-desktop#19037

In the profile pairing flow, when the sender is missing the `ThirdpartyServicesEnabled` field we'll assume the privacy feature isn't implemented by the sender and it's basically disabled. As a result we'll enable `ThirdpartyServicesEnabled` and keep the default field value inline with the DB default.

Author: alexjba

multiaccounts/settings/structs.go

@@ -225,7 +225,7 @@ type Settings struct {
 	PeerSyncingEnabled                  bool                          `json:"peer-syncing-enabled?,omitempty"`
 	AutoRefreshTokensEnabled            bool                          `json:"auto-refresh-tokens-enabled,omitempty"`
 	LastTokensUpdate                    time.Time                     `json:"last-tokens-update,omitempty"`
-	ThirdpartyServicesEnabled           bool                          `json:"thirdparty_services_enabled,omitempty"`
+	ThirdpartyServicesEnabled           bool                          `json:"thirdparty_services_enabled"`
 }
 
 func (s Settings) MarshalJSON() ([]byte, error) {
@@ -251,3 +251,32 @@ func (s Settings) GetFleet() string {
 	}
 	return *s.Fleet
 }
+
+// UnmarshalJSON implements custom unmarshaling for Settings so that when the
+// thirdparty_services_enabled field is missing from incoming JSON it defaults
+// to true instead of the default value (false).
+func (s *Settings) UnmarshalJSON(data []byte) error {
+	// Use an alias to avoid infinite recursion
+	type Alias Settings
+
+	// Temporary struct to check if ThirdpartyServicesEnabled is present
+	aux := &struct {
+		*Alias
+		ThirdpartyServicesEnabled *bool `json:"thirdparty_services_enabled"`
+	}{
+		Alias: (*Alias)(s),
+	}
+
+	if err := json.Unmarshal(data, &aux); err != nil {
+		return err
+	}
+
+	// If the field was omitted, ensure it defaults to true.
+	if aux.ThirdpartyServicesEnabled == nil {
+		s.ThirdpartyServicesEnabled = true
+	} else {
+		s.ThirdpartyServicesEnabled = *aux.ThirdpartyServicesEnabled
+	}
+
+	return nil
+}

multiaccounts/settings/structs_test.go

@@ -0,0 +1,106 @@
+package settings
+
+import (
+	"encoding/json"
+	"testing"
+)
+
+func TestUnmarshal_ThirdpartyServicesEnabled_DefaultsToTrueWhenMissing(t *testing.T) {
+	var s Settings
+	data := []byte(`{}`)
+
+	if err := json.Unmarshal(data, &s); err != nil {
+		t.Fatalf("unmarshal failed: %v", err)
+	}
+
+	if !s.ThirdpartyServicesEnabled {
+		t.Fatalf("expected ThirdpartyServicesEnabled to be true when omitted, got false")
+	}
+}
+
+func TestUnmarshal_ThirdpartyServicesEnabled_RespectsTrue(t *testing.T) {
+	var s Settings
+	data := []byte(`{"thirdparty_services_enabled": true}`)
+
+	if err := json.Unmarshal(data, &s); err != nil {
+		t.Fatalf("unmarshal failed: %v", err)
+	}
+
+	if !s.ThirdpartyServicesEnabled {
+		t.Fatalf("expected ThirdpartyServicesEnabled to be true when explicitly set to true, got false")
+	}
+}
+
+func TestUnmarshal_ThirdpartyServicesEnabled_RespectsFalse(t *testing.T) {
+	var s Settings
+	data := []byte(`{"thirdparty_services_enabled": false}`)
+
+	if err := json.Unmarshal(data, &s); err != nil {
+		t.Fatalf("unmarshal failed: %v", err)
+	}
+
+	if s.ThirdpartyServicesEnabled {
+		t.Fatalf("expected ThirdpartyServicesEnabled to be false when explicitly set to false, got true")
+	}
+}
+
+func TestUnmarshal_ThirdpartyServicesEnabled_NullTreatedAsMissing_DefaultsToTrue(t *testing.T) {
+	var s Settings
+	data := []byte(`{"thirdparty_services_enabled": null}`)
+
+	if err := json.Unmarshal(data, &s); err != nil {
+		t.Fatalf("unmarshal failed: %v", err)
+	}
+
+	if !s.ThirdpartyServicesEnabled {
+		t.Fatalf("expected ThirdpartyServicesEnabled to be true when null (treated as missing), got false")
+	}
+}
+
+func TestMarshal_ThirdpartyServicesEnabled_IncludedWhenTrue(t *testing.T) {
+	s := Settings{ThirdpartyServicesEnabled: true}
+
+	b, err := json.Marshal(&s)
+	if err != nil {
+		t.Fatalf("marshal failed: %v", err)
+	}
+
+	var m map[string]interface{}
+	if err := json.Unmarshal(b, &m); err != nil {
+		t.Fatalf("unmarshal of marshaled bytes failed: %v", err)
+	}
+
+	// When true we expect the key to be present and true
+	v, ok := m["thirdparty_services_enabled"]
+	if !ok {
+		t.Fatalf("expected thirdparty_services_enabled key to be present when true")
+	}
+	if v != true {
+		t.Fatalf("expected thirdparty_services_enabled to be true in JSON, got %v", v)
+	}
+}
+
+func TestMarshal_ThirdpartyServicesEnabled_IncludedWhenFalse(t *testing.T) {
+	s := Settings{ThirdpartyServicesEnabled: false}
+
+	b, err := json.Marshal(&s)
+	if err != nil {
+		t.Fatalf("marshal failed: %v", err)
+	}
+
+	var m map[string]interface{}
+	if err := json.Unmarshal(b, &m); err != nil {
+		t.Fatalf("unmarshal of marshaled bytes failed: %v", err)
+	}
+
+	// The field tag includes `omitempty`, so when false the key is omitted.
+	if _, ok := m["thirdparty_services_enabled"]; ok {
+		// If present, verify it's false
+		if m["thirdparty_services_enabled"] != false {
+			t.Fatalf("expected thirdparty_services_enabled to be false in JSON when present, got %v", m["thirdparty_services_enabled"])
+		}
+	} else {
+		// Key is omitted, which is not acceptable for false
+		t.Fatalf("expected thirdparty_services_enabled key to be present when false")
+	}
+}