Skip to content

Commit c8a616b

Browse files
committed
fix(CommunitiesPortalLayout): Resolve binding loop introduced in recent layout changes
Fix in layout.
1 parent d80f13e commit c8a616b

File tree

1 file changed

+60
-58
lines changed

1 file changed

+60
-58
lines changed

ui/app/AppLayouts/Communities/CommunitiesPortalLayout.qml

Lines changed: 60 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -92,93 +92,95 @@ StatusSectionLayout {
9292
]
9393
}
9494

95-
centerPanel: ColumnLayout {
96-
id: column
97-
95+
centerPanel: Item {
9896
anchors.fill: parent
9997

10098
anchors.topMargin: d.layoutTopMargin
10199
anchors.leftMargin: Theme.xlPadding*2
102100
anchors.rightMargin: Theme.xlPadding
103101

104-
spacing: 18
102+
ColumnLayout {
103+
id: column
105104

106-
StatusBaseText {
107-
Layout.fillWidth: true
108-
text: qsTr("Discover Communities")
109-
font.weight: Font.Bold
110-
font.pixelSize: d.titlePixelSize
111-
color: Theme.palette.directColor1
112-
elide: Text.ElideRight
113-
wrapMode: Text.Wrap
114-
maximumLineCount: 2
115-
}
105+
anchors.fill: parent
106+
spacing: 18
116107

117-
ColumnLayout {
118-
spacing: Theme.padding
108+
StatusBaseText {
109+
Layout.fillWidth: true
110+
text: qsTr("Discover Communities")
111+
font.weight: Font.Bold
112+
font.pixelSize: d.titlePixelSize
113+
color: Theme.palette.directColor1
114+
elide: Text.ElideRight
115+
wrapMode: Text.Wrap
116+
maximumLineCount: 2
117+
}
119118

120-
RowLayout {
121-
SearchBox {
122-
id: searcher
123-
Layout.fillWidth: true
124-
Layout.maximumWidth: 327
125-
Layout.preferredHeight: 38
126-
Layout.alignment: Qt.AlignVCenter
127-
topPadding: 0
128-
bottomPadding: 0
129-
}
119+
ColumnLayout {
120+
spacing: Theme.padding
121+
122+
RowLayout {
123+
SearchBox {
124+
id: searcher
125+
Layout.fillWidth: true
126+
Layout.maximumWidth: 327
127+
Layout.preferredHeight: 38
128+
Layout.alignment: Qt.AlignVCenter
129+
topPadding: 0
130+
bottomPadding: 0
131+
}
130132

131-
// filler
132-
Item {
133-
Layout.fillWidth: true
133+
// filler
134+
Item {
135+
Layout.fillWidth: true
136+
}
137+
138+
LayoutItemProxy {
139+
visible: !d.compactMode
140+
141+
Layout.fillWidth: true
142+
Layout.alignment: Qt.AlignHCenter
143+
144+
target: buttonsRow
145+
}
134146
}
135147

136148
LayoutItemProxy {
137-
visible: !d.compactMode
149+
visible: d.compactMode
138150

139151
Layout.fillWidth: true
140-
Layout.alignment: Qt.AlignHCenter
141152

142153
target: buttonsRow
143154
}
144155
}
145156

146-
LayoutItemProxy {
147-
visible: d.compactMode
148-
157+
TagsRow {
158+
id: communityTags
149159
Layout.fillWidth: true
150160

151-
target: buttonsRow
161+
tags: root.communitiesStore.communityTags
152162
}
153-
}
154163

155-
TagsRow {
156-
id: communityTags
157-
Layout.fillWidth: true
164+
CommunitiesGridView {
165+
id: communitiesGrid
158166

159-
tags: root.communitiesStore.communityTags
160-
}
161-
162-
163-
CommunitiesGridView {
164-
id: communitiesGrid
165-
166-
Layout.fillWidth: true
167-
Layout.fillHeight: true
168-
Layout.leftMargin: d.preventShadowClipMargin
169-
Layout.rightMargin: d.preventShadowClipMargin
167+
Layout.fillWidth: true
168+
Layout.fillHeight: true
169+
Layout.leftMargin: d.preventShadowClipMargin
170+
Layout.rightMargin: d.preventShadowClipMargin
170171

171-
contentWidth: availableWidth
172-
padding: 0
173-
bottomPadding: d.layoutBottomMargin
172+
contentWidth: availableWidth
173+
padding: 0
174+
bottomPadding: d.layoutBottomMargin
174175

175-
model: filteredCommunitiesModel
176-
searchLayout: d.searchMode
176+
model: filteredCommunitiesModel
177+
searchLayout: d.searchMode
177178

178-
assetsModel: root.assetsModel
179-
collectiblesModel: root.collectiblesModel
179+
assetsModel: root.assetsModel
180+
collectiblesModel: root.collectiblesModel
180181

181-
onCardClicked: (communityId) => root.communitiesStore.navigateToCommunity(communityId)
182+
onCardClicked: (communityId) => root.communitiesStore.navigateToCommunity(communityId)
183+
}
182184
}
183185
}
184186

0 commit comments

Comments
 (0)