chore: remove unused transaction request methods (#18955)

Author: igor-sirotin

src/app/modules/main/chat_section/chat_content/input_area/controller.nim

@@ -159,24 +159,6 @@ proc sendChatMessage*(self: Controller,
     paymentRequests
   )
 
-proc requestAddressForTransaction*(self: Controller, fromAddress: string, amount: string, tokenAddress: string) =
-  self.chatService.requestAddressForTransaction(self.chatId, fromAddress, amount, tokenAddress)
-
-proc requestTransaction*(self: Controller, fromAddress: string, amount: string, tokenAddress: string) =
-  self.chatService.requestTransaction(self.chatId, fromAddress, amount, tokenAddress)
-
-proc declineRequestTransaction*(self: Controller, messageId: string) =
-  self.chatService.declineRequestTransaction(messageId)
-
-proc declineRequestAddressForTransaction*(self: Controller, messageId: string) =
-  self.chatService.declineRequestAddressForTransaction(messageId)
-
-proc acceptRequestAddressForTransaction*(self: Controller, messageId: string, address: string) =
-  self.chatService.acceptRequestAddressForTransaction(messageId, address)
-
-proc acceptRequestTransaction*(self: Controller, transactionHash: string, messageId: string, signature: string) =
-  self.chatService.acceptRequestTransaction(transactionHash, messageId, signature)
-
 proc getLinkPreviewEnabled*(self: Controller): bool =
   return self.linkPreviewPersistentSetting == UrlUnfurlingMode.Enabled or self.linkPreviewCurrentMessageSetting == UrlUnfurlingMode.Enabled
 

src/app/modules/main/chat_section/chat_content/input_area/io_interface.nim

@@ -26,24 +26,6 @@ method sendChatMessage*(self: AccessInterface, msg: string, replyTo: string, con
 method sendImages*(self: AccessInterface, imagePathsJson: string, msg: string, replyTo: string, linkPreviews: seq[LinkPreview], paymentRequests: seq[PaymentRequest]) {.base.} =
   raise newException(ValueError, "No implementation available")
 
-method requestAddressForTransaction*(self: AccessInterface, fromAddress: string, amount: string, tokenAddress: string) {.base.} =
-  raise newException(ValueError, "No implementation available")
-
-method requestTransaction*(self: AccessInterface, fromAddress: string, amount: string, tokenAddress: string) {.base.} =
-  raise newException(ValueError, "No implementation available")
-
-method declineRequestTransaction*(self: AccessInterface, messageId: string) {.base.} =
-  raise newException(ValueError, "No implementation available")
-
-method declineRequestAddressForTransaction*(self: AccessInterface, messageId: string) {.base.} =
-  raise newException(ValueError, "No implementation available")
-
-method acceptRequestAddressForTransaction*(self: AccessInterface, messageId: string, address: string) {.base.} =
-  raise newException(ValueError, "No implementation available")
-
-method acceptRequestTransaction*(self: AccessInterface, transactionHash: string, messageId: string, signature: string) {.base.} =
-  raise newException(ValueError, "No implementation available")
-
 method searchGifs*(self: AccessInterface, query: string) {.base.} =
   raise newException(ValueError, "No implementation available")
 

src/app/modules/main/chat_section/chat_content/input_area/module.nim

@@ -79,24 +79,6 @@ method sendChatMessage*(
   self.controller.sendChatMessage(msg, replyTo, contentType,
     singletonInstance.userProfile.getPreferredName(), linkPreviews, paymentRequests)
 
-method requestAddressForTransaction*(self: Module, fromAddress: string, amount: string, tokenAddress: string) =
-  self.controller.requestAddressForTransaction(fromAddress, amount, tokenAddress)
-
-method requestTransaction*(self: Module, fromAddress: string, amount: string, tokenAddress: string) =
-  self.controller.requestTransaction(fromAddress, amount, tokenAddress)
-
-method declineRequestTransaction*(self: Module, messageId: string) =
-  self.controller.declineRequestTransaction(messageId)
-
-method declineRequestAddressForTransaction*(self: Module, messageId: string) =
-  self.controller.declineRequestAddressForTransaction(messageId)
-
-method acceptRequestAddressForTransaction*(self: Module, messageId: string, address: string) =
-  self.controller.acceptRequestAddressForTransaction(messageId, address)
-
-method acceptRequestTransaction*(self: Module, transactionHash: string, messageId: string, signature: string) =
-  self.controller.acceptRequestTransaction(transactionHash, messageId, signature)
-
 method setText*(self: Module, text: string, unfurlNewUrls: bool) =
   self.controller.setText(text, unfurlNewUrls)
 

src/app/modules/main/chat_section/chat_content/input_area/view.nim

@@ -63,24 +63,6 @@ QtObject:
     self.delegate.setText(msg, false)
     self.delegate.sendImages(imagePathsJson, msg, replyTo, self.linkPreviewModel.getUnfuledLinkPreviews(), self.payment_request_model.getPaymentRequests())
 
-  proc acceptAddressRequest*(self: View, messageId: string , address: string) {.slot.} =
-    self.delegate.acceptRequestAddressForTransaction(messageId, address)
-
-  proc declineAddressRequest*(self: View, messageId: string) {.slot.} =
-    self.delegate.declineRequestAddressForTransaction(messageId)
-
-  proc requestAddress*(self: View, fromAddress: string, amount: string, tokenAddress: string) {.slot.} =
-    self.delegate.requestAddressForTransaction(fromAddress, amount, tokenAddress)
-
-  proc request*(self: View, fromAddress: string, amount: string, tokenAddress: string) {.slot.} =
-    self.delegate.requestTransaction(fromAddress, amount, tokenAddress)
-
-  proc declineRequest*(self: View, messageId: string) {.slot.} =
-    self.delegate.declineRequestTransaction(messageId)
-
-  proc acceptRequestTransaction*(self: View, transactionHash: string, messageId: string, signature: string) {.slot.} =
-    self.delegate.acceptRequestTransaction(transactionHash, messageId, signature)
-
   proc getPreservedProperties(self: View): QVariant {.slot.} =
     return self.preservedPropertiesVariant
 

src/app_service/service/chat/service.nim

@@ -12,14 +12,12 @@ import ../contacts/service as contact_service
 import backend/chat as status_chat
 import backend/communities as status_communities
 import backend/group_chat as status_group_chat
-import backend/chatCommands as status_chat_commands
 import app/global/[global_singleton, utils]
 import app/core/eventemitter
 import app/core/signals/types
 import constants
 
 import ../../common/message as message_common
-from ../../common/account_constants import ZERO_ADDRESS
 
 export chat_dto
 
@@ -326,11 +324,6 @@ QtObject:
       self.updateOrAddChat(chat)
       self.signalChatsAndMessagesUpdates(@[chat], messages)
 
-  proc processUpdateForTransaction*(self: Service, messageId: string, response: RpcResponse[JsonNode]) =
-    var (chats, _) = self.processMessengerResponse(response)
-    # TODO: Signal is not handled anywhere
-    self.events.emit(SIGNAL_MESSAGE_REMOVE, MessageArgs(id: messageId, channel: chats[0].id))
-
   proc parseChatResponseAndEmit*(self: Service, response: RpcResponse[JsonNode]) =
     var (chats, _) = self.parseChatResponse(response)
     self.events.emit(SIGNAL_CHAT_UPDATE, ChatUpdateArgs(chats: chats))
@@ -521,50 +514,6 @@ QtObject:
       error "Error sending message", msg = e.msg
       self.events.emit(SIGNAL_SENDING_FAILED, MessageSendingFailure(chatId: rpcResponseObj["chatId"].getStr, error: e.msg))
 
-  proc requestAddressForTransaction*(self: Service, chatId: string, fromAddress: string, amount: string, tokenAddress: string) =
-    try:
-      let address = if (tokenAddress == ZERO_ADDRESS): "" else: tokenAddress
-      let response =  status_chat_commands.requestAddressForTransaction(chatId, fromAddress, amount, address)
-      discard self.processMessengerResponse(response)
-    except Exception as e:
-      error "Error requesting address for transaction", msg = e.msg
-
-  proc requestTransaction*(self: Service, chatId: string, fromAddress: string, amount: string, tokenAddress: string) =
-    try:
-      let address = if (tokenAddress == ZERO_ADDRESS): "" else: tokenAddress
-      let response = status_chat_commands.requestTransaction(chatId, fromAddress, amount, address)
-      discard self.processMessengerResponse(response)
-    except Exception as e:
-      error "Error requesting transaction", msg = e.msg
-
-  proc declineRequestTransaction*(self: Service, messageId: string) =
-    try:
-      let response = status_chat_commands.declineRequestTransaction(messageId)
-      self.processUpdateForTransaction(messageId, response)
-    except Exception as e:
-      error "Error requesting transaction", msg = e.msg
-
-  proc declineRequestAddressForTransaction*(self: Service, messageId: string) =
-    try:
-      let response = status_chat_commands.declineRequestAddressForTransaction(messageId)
-      self.processUpdateForTransaction(messageId, response)
-    except Exception as e:
-      error "Error requesting transaction", msg = e.msg
-
-  proc acceptRequestAddressForTransaction*(self: Service, messageId: string, address: string) =
-    try:
-      let response = status_chat_commands.acceptRequestAddressForTransaction(messageId, address)
-      self.processUpdateForTransaction(messageId, response)
-    except Exception as e:
-      error "Error requesting transaction", msg = e.msg
-
-  proc acceptRequestTransaction*(self: Service, transactionHash: string, messageId: string, signature: string) =
-    try:
-      let response = status_chat_commands.acceptRequestTransaction(transactionHash, messageId, signature)
-      discard self.processMessengerResponse(response)
-    except Exception as e:
-      error "Error requesting transaction", msg = e.msg
-
   proc muteChat*(self: Service, chatId: string, interval: int) =
     try:
       if(chatId.len == 0):

src/backend/chatCommands.nim

@@ -530,22 +530,6 @@ QtObject {
         return profileSectionModule.ensUsernamesModule.getFiatValue(balance, cryptoSymbol, fiatSymbol)
     }
 
-    function acceptRequestTransaction(transactionHash, messageId, signature) {
-        return currentChatContentModule().inputAreaModule.acceptRequestTransaction(transactionHash, messageId, signature)
-    }
-
-    function acceptAddressRequest(messageId, address) {
-        currentChatContentModule().inputAreaModule.acceptAddressRequest(messageId, address)
-    }
-
-    function declineAddressRequest(messageId) {
-        currentChatContentModule().inputAreaModule.declineAddressRequest(messageId)
-    }
-
-    function declineRequest(messageId) {
-        currentChatContentModule().inputAreaModule.declineRequest(messageId)
-    }
-
     function resolveENS(value) {
         mainModuleInst.resolveENS(value, "")
     }