Skip to content

Conversation

@nimrod-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

Artifacts upload workflows:

@nimrod-starkware nimrod-starkware marked this pull request as ready for review November 26, 2025 13:31
@nimrod-starkware nimrod-starkware self-assigned this Nov 26, 2025
Copy link
Contributor

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@yoavGrs reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)


a discussion (no related file):
can you open a py-side pr to make sure there is no runtime issue with computing block hash?


crates/starknet_api/src/block_hash/block_hash_calculator.rs line 231 at r1 (raw file):

    let (transaction_commitment, event_commitment, receipt_commitment, state_diff_commitment) =
        tokio::try_join!(transaction_task, event_task, receipt_task, state_diff_task)
            .expect("Failed to join block commitments tasks.");

why spawn_blocking and not spawn?

Code quote:

    // Spawn tasks for parallel execution
    let transaction_task = spawn_blocking(move || {
        calculate_transaction_commitment::<Poseidon>(&transaction_leaf_elements)
    });

    let event_task =
        spawn_blocking(move || calculate_event_commitment::<Poseidon>(&event_leaf_elements));

    let receipt_task =
        spawn_blocking(move || calculate_receipt_commitment::<Poseidon>(&receipt_elements));

    let state_diff_task = spawn_blocking(move || calculate_state_diff_hash(&state_diff));

    // Wait for all tasks to complete.
    let (transaction_commitment, event_commitment, receipt_commitment, state_diff_commitment) =
        tokio::try_join!(transaction_task, event_task, receipt_task, state_diff_task)
            .expect("Failed to join block commitments tasks.");

Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware)


a discussion (no related file):

Previously, dorimedini-starkware wrote…

can you open a py-side pr to make sure there is no runtime issue with computing block hash?

https://github.com/starkware-industries/starkware/pull/39579
Passed without any op, can i close?

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)


a discussion (no related file):

Previously, nimrod-starkware wrote…

https://github.com/starkware-industries/starkware/pull/39579
Passed without any op, can i close?

yes

Copy link
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_api/src/block_hash/block_hash_calculator.rs line 231 at r1 (raw file):

Previously, dorimedini-starkware wrote…

why spawn_blocking and not spawn?

Discussed offline

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)

@nimrod-starkware nimrod-starkware added this pull request to the merge queue Nov 30, 2025
Merged via the queue into main-v0.14.1-committer with commit b7d2e1d Nov 30, 2025
40 of 45 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants