Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using network names as network url #1303

Open
aryzing opened this issue Jan 29, 2025 · 0 comments
Open

Using network names as network url #1303

aryzing opened this issue Jan 29, 2025 · 0 comments
Labels
Type: bug Something isn't working

Comments

@aryzing
Copy link

aryzing commented Jan 29, 2025

Describe the bug
Parameter name doesn't reflect the underlying data

To Reproduce
When creating a provider, such as with:

const myProvider = new RpcProvider({ nodeUrl: constants.NetworkName.SN_MAIN });

a network name, accessed under the NetworkName prop, is being assigned to a prop called nodeUrl, which should accept a URL.

Expected behavior
The prop name should match the data being assigned to it.

  • If it's a network name, it should be called nodeName
  • If it's a network URL, it should be called nodeUrl
@aryzing aryzing added the Type: bug Something isn't working label Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant