Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Leverage Secret resources for BMC credentials #4

Open
starbops opened this issue Feb 23, 2024 · 0 comments
Open

[FEATURE] Leverage Secret resources for BMC credentials #4

starbops opened this issue Feb 23, 2024 · 0 comments
Assignees
Labels
component/manager Relevant to the custom Kubernetes controllers kind/feature New feature proposed/asked

Comments

@starbops
Copy link
Owner

Is your feature request related to a problem? Please describe.

The username and password of the BMC are currently stored in the KubeBMC object:

// KubeBMCSpec defines the desired state of KubeBMC
type KubeBMCSpec struct {
	// INSERT ADDITIONAL SPEC FIELDS - desired state of cluster
	// Important: Run "make" to regenerate code after modifying this file

	// To authenticate who the user is.
	// +optional
	Username string `json:"username,omitempty"`

	// The credential part of the IPMI service
	// +optional
	Password string `json:"password,omitempty"`

	// The namespace where the virtual machine is in
	VirtualMachineNamespace string `json:"vmNamespace"`

	// The actual virtual machine that this BMC controls
	VirtualMachineName string `json:"vmName"`
}

It would be great if we dropped the credential part from KubeBMC CRD and made it associated with a Secret object.

Describe the solution you'd like

Put the credential part into Secret objects and associate KubeBMC objects with them.

Describe alternatives you've considered

N/A

Additional context

N/A

@starbops starbops added the kind/feature New feature proposed/asked label Jul 28, 2024
@starbops starbops moved this to Backlog in KubeVirtBMC project Nov 11, 2024
@starbops starbops moved this from Backlog to Ready in KubeVirtBMC project Nov 11, 2024
@starbops starbops self-assigned this Nov 18, 2024
@starbops starbops added the component/manager Relevant to the custom Kubernetes controllers label Jan 3, 2025
@starbops starbops moved this from Ready to In progress in KubeVirtBMC project Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/manager Relevant to the custom Kubernetes controllers kind/feature New feature proposed/asked
Projects
Status: In progress
Development

No branches or pull requests

1 participant