Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle files with dspy installation #7855

Merged
merged 2 commits into from
Feb 27, 2025
Merged

bundle files with dspy installation #7855

merged 2 commits into from
Feb 27, 2025

Conversation

arnavsinghvi11
Copy link
Collaborator

@arnavsinghvi11 arnavsinghvi11 commented Feb 26, 2025

fix for #7853 and #7490

ensures all github files are in the dspy installation package so runner.js can be recognized.

Tagging @chenmoneygithub for review on the proper pypi package installation.

Copy link
Collaborator

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We should probably go with the following style to give us control over extra files to include instead of including everything:

[tool.setuptools]
packages = ["dspy"] 

[tool.setuptools.package-data]
"dspy" = ["primitives/*.js"]

@chenmoneygithub
Copy link
Collaborator

I pushed a commit to explicitly list out the non-python files, testing result:

(always-clean) [package_bundling][~/Documents/mlflow_team/dspy/dist]$ ls dspy-2.6.6/dspy/primitives
__init__.py           module.py             python_interpreter.py
assertions.py         prediction.py         runner.js
example.py            program.py            tool.py

I can see the runner.js in the extracted directory.

@chenmoneygithub chenmoneygithub merged commit ba2ea6e into main Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants