You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I try to run pre-commit run --all-files in the repo, it generates a huge diff with 338 affected files. Considering the pre-commit setup was in place for a while, running this command on the main branch shouldn't change any file.
I checked what's going on with the related CI workflow and apparently, it's been broken for a while:
The workflow is not valid. .github/workflows/precommits_check.yml (Line: 18, Col: 5): Required property is missing: runs-on
I'd like to fix this issue and apply fixes to the repo, and then update and improve the pre-commit config. My initial goal was to clean the residues left from Python 3.8* and then add pyupgrade to the repo; but it turned out that pre-commit config needs some work first.
@ulgens Thanks for reporting the issue! We are not enforcing pre-commit rules right now. Exactly as you have observed, running autoformatting will generate a huge diff list. We are in the middle of standardizing the coding style, and will fix it in a progressive way to avoid breakage.
What happened?
When I try to run
pre-commit run --all-files
in the repo, it generates a huge diff with 338 affected files. Considering the pre-commit setup was in place for a while, running this command on the main branch shouldn't change any file.I checked what's going on with the related CI workflow and apparently, it's been broken for a while:
https://github.com/stanfordnlp/dspy/actions/runs/8059208679
Steps to reproduce
pre-commit run --all-files
on the main branch's latestgit status
outputDSPy version
main
The text was updated successfully, but these errors were encountered: