Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] pre-commit workflow is broken #7823

Open
ulgens opened this issue Feb 20, 2025 · 2 comments
Open

[Bug] pre-commit workflow is broken #7823

ulgens opened this issue Feb 20, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@ulgens
Copy link
Contributor

ulgens commented Feb 20, 2025

What happened?

When I try to run pre-commit run --all-files in the repo, it generates a huge diff with 338 affected files. Considering the pre-commit setup was in place for a while, running this command on the main branch shouldn't change any file.

I checked what's going on with the related CI workflow and apparently, it's been broken for a while:

The workflow is not valid. .github/workflows/precommits_check.yml (Line: 18, Col: 5): Required property is missing: runs-on

https://github.com/stanfordnlp/dspy/actions/runs/8059208679

Steps to reproduce

  • Run pre-commit run --all-files on the main branch's latest
  • Check the git status output

DSPy version

main

@ulgens ulgens added the bug Something isn't working label Feb 20, 2025
@ulgens
Copy link
Contributor Author

ulgens commented Feb 20, 2025

I'd like to fix this issue and apply fixes to the repo, and then update and improve the pre-commit config. My initial goal was to clean the residues left from Python 3.8* and then add pyupgrade to the repo; but it turned out that pre-commit config needs some work first.

* PyPI is using the misleading metadata:

Image

@chenmoneygithub
Copy link
Collaborator

@ulgens Thanks for reporting the issue! We are not enforcing pre-commit rules right now. Exactly as you have observed, running autoformatting will generate a huge diff list. We are in the middle of standardizing the coding style, and will fix it in a progressive way to avoid breakage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants