Custom features in NER package should use dependency injection

[mcalpin]

To add a custom feature extractor to the NER package, the path of least resistance is to modify NERFeatureFactory.java, AnnotationLookup.java, CoreAnnotations.java and SeqClassifierFlags.java. A more generic approach would use dependency injection, so third-party developers wouldn't have to touch code inside CoreNLP. If it's not already on your development roadmap, I'm happy to take on that change.

Dave

[AngledLuffa]

That's not on our radar, but we'd be happy to look at a proposed change,

John

On Sun, Nov 17, 2013 at 1:21 PM, mcalpin notifications@github.com wrote:

To add a custom feature extractor to the NER package, the path of least
resistance is to modify NERFeatureFactory.java, AnnotationLookup.java,
CoreAnnotations.java and SeqClassifierFlags.java. A more generic approach
would use dependency injection, so third-party developers wouldn't have to
touch code inside CoreNLP. If it's not already on your development roadmap,
I'm happy to take on that change.

Dave

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/6
.