Skip to content

Commit b8fed45

Browse files
authored
Attempt to clean up lint situation again (#32)
1 parent eeeb632 commit b8fed45

File tree

3 files changed

+35
-36
lines changed

3 files changed

+35
-36
lines changed

.github/workflows/hedwig.yml

Lines changed: 35 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -11,59 +11,70 @@ on:
1111
types: [opened, repoened, synchronize]
1212

1313
jobs:
14-
native-test:
14+
lint:
1515
runs-on: ${{ matrix.os }}
1616
strategy:
1717
fail-fast: false
1818
matrix:
19-
rust_toolchain: [nightly, stable, 1.49.0]
2019
os: [ubuntu-latest, windows-latest, macOS-latest]
21-
timeout-minutes: 20
20+
timeout-minutes: 10
2221
steps:
2322
- uses: actions/checkout@v2
24-
- name: Install Rust ${{ matrix.rust_toolchain }}
23+
- name: Install Rust
2524
uses: actions-rs/toolchain@v1
2625
with:
27-
toolchain: ${{ matrix.rust_toolchain }}
26+
toolchain: stable
2827
profile: minimal
2928
components: clippy
3029
default: true
31-
- name: Update
32-
uses: actions-rs/cargo@v1
33-
with:
34-
command: update
35-
args: --manifest-path=Cargo.toml
3630
- name: Clippy
3731
uses: actions-rs/cargo@v1
3832
with:
3933
command: clippy
40-
args: -- -Arenamed-and-removed-lints -Aclippy::unknown-clippy-lints -Aunknown-lints
34+
args: -- -Dclippy::correctness -Dclippy::complexity -Dclippy::perf -Dunsafe_code -Dunreachable_pub -Dunused
35+
36+
doc:
37+
runs-on: ubuntu-latest
38+
timeout-minutes: 10
39+
steps:
40+
- uses: actions/checkout@v2
41+
- name: Install Rust
42+
uses: actions-rs/toolchain@v1
43+
with:
44+
toolchain: nightly
45+
profile: minimal
46+
default: true
4147
- name: Doc
4248
uses: actions-rs/cargo@v1
4349
with:
4450
command: doc
4551
args: --all-features --manifest-path=Cargo.toml
4652
env:
47-
RUSTDOCFLAGS: --cfg docsrs -Arenamed-and-removed-lints -Aunknown-lints
48-
if: ${{ matrix.rust_toolchain == 'nightly' }}
53+
RUSTDOCFLAGS: --cfg docsrs -Dmissing_docs -Dbroken_intra_doc_links
54+
55+
test:
56+
runs-on: ${{ matrix.os }}
57+
strategy:
58+
fail-fast: false
59+
matrix:
60+
rust_toolchain: [nightly, stable, 1.49.0]
61+
os: [ubuntu-latest, windows-latest, macOS-latest]
62+
timeout-minutes: 20
63+
steps:
64+
- uses: actions/checkout@v2
65+
- name: Install Rust ${{ matrix.rust_toolchain }}
66+
uses: actions-rs/toolchain@v1
67+
with:
68+
toolchain: ${{ matrix.rust_toolchain }}
69+
profile: minimal
70+
default: true
4971
- name: Build without features
5072
uses: actions-rs/cargo@v1
5173
with:
5274
command: build
5375
args: --no-default-features --manifest-path=Cargo.toml
54-
env:
55-
RUSTFLAGS: -Arenamed-and-removed-lints -Aunknown-lints -Arenamed-and-removed-lints
56-
- name: Build with `google` feature
57-
uses: actions-rs/cargo@v1
58-
with:
59-
command: build
60-
args: --manifest-path=Cargo.toml --features=google
61-
env:
62-
RUSTFLAGS: -Arenamed-and-removed-lints -Aunknown-lints -Arenamed-and-removed-lints
6376
- name: Test with all features
6477
uses: actions-rs/cargo@v1
6578
with:
6679
command: test
6780
args: --manifest-path=Cargo.toml --all-features -- --nocapture
68-
env:
69-
RUSTFLAGS: -Arenamed-and-removed-lints -Aunknown-lints -Arenamed-and-removed-lints

src/lib.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -94,16 +94,6 @@
9494
//! # Ok(())
9595
//! # }
9696
//! ```
97-
#![deny(
98-
missing_docs,
99-
broken_intra_doc_links,
100-
clippy::correctness,
101-
clippy::complexity,
102-
clippy::perf,
103-
unsafe_code,
104-
unreachable_pub
105-
)]
106-
#![cfg_attr(not(test), deny(unused))]
10797
#![cfg_attr(docsrs, feature(doc_cfg))]
10898

10999
use std::{borrow::Cow, collections::BTreeMap, time::SystemTime};

src/publish/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,8 +177,6 @@ where
177177
fn poll_next(self: Pin<&mut Self>, cx: &mut Context) -> Poll<Option<Self::Item>> {
178178
let this = self.project();
179179

180-
// `map` has lifetime constraints that aren't nice here
181-
#[allow(clippy::manual_map)]
182180
Poll::Ready(match ready!(this.publish_stream.poll_next(cx)) {
183181
None => None,
184182
Some(stream_item) => Some((

0 commit comments

Comments
 (0)