Skip to content

double version of trace_gen_quad_form is never used #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcol opened this issue Feb 13, 2020 · 2 comments · Fixed by #1628
Closed

double version of trace_gen_quad_form is never used #1709

mcol opened this issue Feb 13, 2020 · 2 comments · Fixed by #1628

Comments

@mcol
Copy link
Contributor

mcol commented Feb 13, 2020

Description

There's an unresolved typename declared for trace_gen_quad_form, which therefore is never used even when all inputs are double. Here's the definition:

template <int RD, int CD, int RA, int CA, typename TB, int RB, int CB>
inline double trace_gen_quad_form(const Eigen::Matrix<double, RD, CD> &D,
                                  const Eigen::Matrix<double, RA, CA> &A,
                                  const Eigen::Matrix<double, RB, CB> &B)

Removing typename TB allows that double specialization to be used.

Current Version:

v3.1.0

@mcol mcol added this to the 3.1.0++ milestone Feb 13, 2020
@rok-cesnovar
Copy link
Member

This one will be squashed by #1628 right?

@mcol
Copy link
Contributor Author

mcol commented Feb 13, 2020

Good to know, I hadn't seen that! :)

@mcol mcol linked a pull request Feb 13, 2020 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants