-
-
Notifications
You must be signed in to change notification settings - Fork 193
Windows compiler segfaults #1615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for catching this! I've got a similar issue here: https://jenkins.mc-stan.org/blue/organizations/jenkins/Stan/detail/downstream_tests/1148/pipeline The math tests pass on Windows, but the downstream tests segfault. |
@t4c1 brought this to my attention. I am now trying to get a reliable way to replicate this locally or on Jenkins. It seems that #1558 is experiencing this issue the most reliably on the upstream test. Will branch off of that and abuse Jenkins for debugging a bit. Its probably either the master includes like <stan/math/prim/err.hpp> or the added templating. I am hoping its the first, as the latter would be really disappointing. |
Not sure if you need other reports, but here's one: https://jenkins.mc-stan.org/blue/organizations/jenkins/Math%20Pipeline/detail/PR-1612/9/pipeline/174 |
Thanks to everyone tagging me, I should have time to get to the bottom of this tomorrow. |
@serban-nicusor-toptal quick question. Can you tell me anything about which Windows machine was used for this two tests: and these two: Or even better, tell me where I can look that for myself if at all possible. I know you probably told me this a couple of times, sorry :) |
Stan, downstream_tests, 1147: Getting this through Jenkins is a pain because Chromes just hangs with more than 4MB data on a page ( even on high-end pcs ).
I'm currently in the process of building more detailed documentation about Jenkins from jobs to debug procedures so it brings a bit more transparency and others can review CI/CD stages and spot issues more easily. If I can help with anything else please let me know! |
Thanks, that more or less confirms it that is not an issue related to a specific machine. I am still struggling to reproduce this locally. How much RAM is given to Jenkins on Windows? The first issue some time ago was that it was only allowing it to use 1GB of RAM right? How much does it have now? That could potentially be an issue here, since more C++ templating and using master includes means more RAM is needed for the compilation stage. |
Just Jenkins java process was affected by RAM limits, I was wrong in thinking that it will affect processes ran by it. So any process ran by Jenkins will use all the available RAM. What I found out while fixing some bugs is that some jobs require more swap that the default allocated. Windows allocate around 50 MB which is very low so I had to increase it. Can't give you exact amount/server now but I will update the below when I get home. ( forgot to add swap specifications ) If you want to see other machine specs I've made a list here note that it may change! |
@serban-nicusor-toptal you fixed those swaps a few days ago right? There were no segfaults on Windows Jenkins tests for a day now and I still cant reproduce locally... |
Hey, I've checked now and the windows machines have respectively 20 and 25 GB swap so more than enough. The issue with If it helps in any way, math PRs that failed lately are: PR-1525, PR-1607, PR-1604, PR-1558, PR-1612. Please tell me how I can help you to figure this out While going through the logs I found these, not sure if related:
|
The ones with "internal compiler error: Segmentation fault" are related and those should be looked at. I looked at https://jenkins.mc-stan.org/blue/organizations/jenkins/Stan/detail/downstream_tests/1147/pipeline/66 which all failed for this reason and they all ran on |
If these are limited to a single machine that doesnt have enough resources to handle this, that would be the best case scenario. We will just reduce the parallel env var and should be good. |
All of the above are extracted from segfault jobs. |
I am thinking more in the line that it segfaults as it runs out of RAM in multi-threaded compilation. |
Yes, I've found one. Give me a sec to find it. |
You are actually right, it only happened on the new windows instance. The failures on the other one weren't related to segmentation fault. |
Thanks! |
I think this confirms it: https://jenkins.mc-stan.org/blue/organizations/jenkins/Stan/detail/downstream_tests/1156/pipeline/66 |
Thank you for the help. Closing for now, if any such error occurs again, we can reopen. |
Thanks all for figuring this out! |
Description
We are experiencing some compiler segmentation faults lately on Jenkins Windows machines. These are most probably related to the flatten and limitations of g++ 4.9.3.
If the flatten and increased file sizes is not the culprit I would suspect PR #1471 that introduced additional templating.
Examples of failures:
https://jenkins.mc-stan.org/blue/organizations/jenkins/Math%20Pipeline/detail/PR-1603/9/pipeline/
https://jenkins.mc-stan.org/blue/organizations/jenkins/Math%20Pipeline/detail/PR-1610/4/
If anyone sees a similar error on Jenkins please post it here! And if anyone can replicate this locally, also please post more info. So far I was unable to replicate locally.
We have 4 more days until the release to figure out:
Current Version:
v3.0.0
The text was updated successfully, but these errors were encountered: