Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Earlier departure" and "Later departure" options do not update the time for Bike&Ride routes (web and app) #867

Open
stadtnavimanager opened this issue Dec 20, 2024 · 3 comments

Comments

@stadtnavimanager
Copy link
Collaborator

Description:

When using the "Earlier departure" or "Later departure" buttons in the route overview, the departure time for Bike&Ride routes does not update.

To adjust the time for Bike&Ride routes, users must manually navigate to the time settings and change it there, which adds unnecessary complexity to the user experience.


Steps to reproduce:

  1. Perform a route search in stadtnavi that includes Bike&Ride, e.g. https://dev.stadtnavi.eu/reiseplan/Stuttgart%20Hauptbahnhof%2C%20Stuttgart%3A%3A48.7856099%2C9.1833959/Degerloch%2C%2070597%20Stuttgart%3A%3A48.749597%2C9.1703452/bikeAndVehicle?time=1734699240
  2. In the overview, click on "Earlier departure" or "Later departure".
  3. Observe whether the departure time updates for Bike&Ride routes.

Observed behavior:

  • The departure time for Bike&Ride routes remains unchanged when selecting "Earlier departure" or "Later departure".

Expected behavior:

  • The departure time should adjust accordingly when "Earlier departure" or "Later departure" is selected, reflecting the updated time in the Bike&Ride route suggestions.

Screenshots:

Image
Image


Environment:

Browser and App


Additional information:

Improving this functionality will make the time adjustment process more intuitive and consistent across all route types.

@andreashelms
Copy link
Collaborator

For digitransit-ui the are no "Earlier departure" or "Later departure" buttons if a specific transport mode e.g. bike & ride has been selected.

Image

Buttons are only shown for general route suggestions.

Image

Should these buttons be added for specific transport mode selections?

@andreashelms
Copy link
Collaborator

These buttons are explicitly disabled if Bike & Ride is selected. If I enable the buttons, the query for earlier itineraries does not work. Looks like I have to put more effort on that than just enabling the buttons.

@andreashelms
Copy link
Collaborator

@hbruch To enable requesting earlier/later connection for Bike&Ride I need to implement multi mode requests for the moreItinerariesQuery to receive Bike + Transit, BikePark + Transit, BikeRent + Transit connections. This is not possible with the current implementation, therefore I would need to do some more refactoring and spend about 1 day additional effort on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants