Merge pull request #19 from stackkit/development

Fix config closure

Author: marickvantuil

phpunit.xml

@@ -7,8 +7,7 @@
          convertNoticesToExceptions="true"
          convertWarningsToExceptions="true"
          processIsolation="false"
-         stopOnFailure="false"
-         syntaxCheck="false">
+         stopOnFailure="false">
 
     <testsuites>
         <testsuite name="Orchestra\Testbench Test Suite">

src/Config.php

@@ -31,13 +31,7 @@ public static function encryptEmails()
      */
     public static function testing()
     {
-        $testing = config('laravel-database-emails.testing.enabled', function () {
-            return function () {
-                return false;
-            };
-        });
-
-        return $testing();
+        return (bool) config('laravel-database-emails.testing.enabled', false);
     }
 
     /**

tests/ConfigTest.php

@@ -0,0 +1,58 @@
+<?php
+
+namespace Tests;
+
+use Stackkit\LaravelDatabaseEmails\Config;
+
+class ConfigTest extends TestCase
+{
+    /** @test */
+    public function test_max_attempt_count()
+    {
+        $this->assertEquals(3, Config::maxAttemptCount());
+
+        $this->app['config']->set('laravel-database-emails.attempts', 5);
+
+        $this->assertEquals(5, Config::maxAttemptCount());
+    }
+
+    /** @test */
+    public function test_encrypt_emails()
+    {
+        $this->assertFalse(Config::encryptEmails());
+
+        $this->app['config']->set('laravel-database-emails.encrypt', true);
+
+        $this->assertTrue(Config::encryptEmails());
+    }
+
+    /** @test */
+    public function test_testing()
+    {
+        $this->assertFalse(Config::testing());
+
+        $this->app['config']->set('laravel-database-emails.testing.enabled', true);
+
+        $this->assertTrue(Config::testing());
+    }
+
+    /** @test */
+    public function test_test_email_address()
+    {
+        $this->assertEquals('[email protected]', Config::testEmailAddress());
+
+        $this->app['config']->set('laravel-database-emails.testing.email', '[email protected]');
+
+        $this->assertEquals('[email protected]', Config::testEmailAddress());
+    }
+
+    /** @test */
+    public function test_cronjob_email_limit()
+    {
+        $this->assertEquals(20, Config::cronjobEmailLimit());
+
+        $this->app['config']->set('laravel-database-emails.limit', 15);
+
+        $this->assertEquals(15, Config::cronjobEmailLimit());
+    }
+}

tests/TestCase.php

@@ -79,6 +79,8 @@ protected function getPackageProviders($app)
     protected function getEnvironmentSetUp($app)
     {
         $app['config']->set('laravel-database-emails.attempts', 3);
+        $app['config']->set('laravel-database-emails.testing.enabled', false);
+        $app['config']->set('laravel-database-emails.testing.email', '[email protected]');
 
         $app['config']->set('database.default', 'testbench');
         $app['config']->set('database.connections.testbench', [