chore(load-balancer): make linter happy

Author: j1n-o9r

internal/cmd/load-balancer/describe/describe.go

@@ -129,15 +129,15 @@ func buildLoadBalancerTable(loadBalancer *loadbalancer.LoadBalancer) tables.Tabl
 	}
 
 	networkId := "-"
-	if loadBalancer.Networks != nil && len(loadBalancer.Networks) > 0 {
+	if len(loadBalancer.Networks) > 0 {
 		networks := loadBalancer.Networks
 		networkId = *networks[0].NetworkId
 	}
 
 	externalAddress := utils.PtrStringDefault(loadBalancer.ExternalAddress, "-")
 
 	var errorDescriptions []string
-	if loadBalancer.Errors != nil && len(loadBalancer.Errors) > 0 {
+	if len(loadBalancer.Errors) > 0 {
 		for _, err := range loadBalancer.Errors {
 			errorDescriptions = append(errorDescriptions, *err.Description)
 		}

internal/cmd/load-balancer/observability-credentials/cleanup/cleanup.go

@@ -60,7 +60,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
 			}
 
 			var credentials []loadbalancer.CredentialsResponse
-			if resp.Credentials != nil && len(resp.Credentials) > 0 {
+			if len(resp.Credentials) > 0 {
 				credentials, err = utils.FilterCredentials(ctx, apiClient.DefaultAPI, resp.Credentials, model.ProjectId, model.Region, utils.OP_FILTER_UNUSED)
 				if err != nil {
 					return fmt.Errorf("filter Load Balancer observability credentials: %w", err)

internal/cmd/load-balancer/observability-credentials/update/update_test.go

@@ -8,10 +8,11 @@ import (
 	"github.com/google/go-cmp/cmp"
 	"github.com/google/go-cmp/cmp/cmpopts"
 	"github.com/google/uuid"
+	loadbalancer "github.com/stackitcloud/stackit-sdk-go/services/loadbalancer/v2api"
+
 	"github.com/stackitcloud/stackit-cli/internal/pkg/globalflags"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/testutils"
 	"github.com/stackitcloud/stackit-cli/internal/pkg/utils"
-	loadbalancer "github.com/stackitcloud/stackit-sdk-go/services/loadbalancer/v2api"
 )
 
 const (
@@ -34,7 +35,7 @@ type mockSettings struct {
 
 func newAPIMock(s mockSettings) loadbalancer.DefaultAPI {
 	return &loadbalancer.DefaultAPIServiceMock{
-		GetCredentialsExecuteMock: utils.Ptr(func(r loadbalancer.ApiGetCredentialsRequest) (*loadbalancer.GetCredentialsResponse, error) {
+		GetCredentialsExecuteMock: utils.Ptr(func(_ loadbalancer.ApiGetCredentialsRequest) (*loadbalancer.GetCredentialsResponse, error) {
 			if s.getCredentialsError {
 				return nil, fmt.Errorf("get credentials failed")
 			}
@@ -43,17 +44,6 @@ func newAPIMock(s mockSettings) loadbalancer.DefaultAPI {
 	}
 }
 
-func (c *mockSettings) UpdateCredentials(ctx context.Context, projectId, region, credentialsRef string) loadbalancer.ApiUpdateCredentialsRequest {
-	return testClient.DefaultAPI.UpdateCredentials(ctx, projectId, region, credentialsRef)
-}
-
-func (c *mockSettings) GetCredentialsExecute(_ context.Context, _, _, _ string) (*loadbalancer.GetCredentialsResponse, error) {
-	if c.getCredentialsError {
-		return nil, fmt.Errorf("get credentials failed")
-	}
-	return c.getCredentialsResponse, nil
-}
-
 func fixtureArgValues(mods ...func(argValues []string)) []string {
 	argValues := []string{
 		testCredentialsRef,

internal/cmd/load-balancer/target-pool/add-target/add_target_test.go

@@ -335,7 +335,7 @@ func TestBuildRequest(t *testing.T) {
 						},
 					}
 				})
-				*request = (*request).UpdateTargetPoolPayload(*payload)
+				*request = request.UpdateTargetPoolPayload(*payload)
 			}),
 		},
 		{
@@ -354,7 +354,7 @@ func TestBuildRequest(t *testing.T) {
 						},
 					}
 				})
-				*request = (*request).UpdateTargetPoolPayload(*payload)
+				*request = request.UpdateTargetPoolPayload(*payload)
 			}),
 		},
 		{
@@ -373,7 +373,7 @@ func TestBuildRequest(t *testing.T) {
 						},
 					}
 				})
-				*request = (*request).UpdateTargetPoolPayload(*payload)
+				*request = request.UpdateTargetPoolPayload(*payload)
 			}),
 		},
 		{

internal/cmd/load-balancer/target-pool/remove-target/remove_target_test.go

@@ -316,7 +316,7 @@ func TestBuildRequest(t *testing.T) {
 				payload := fixturePayload(func(payload *loadbalancer.UpdateTargetPoolPayload) {
 					payload.Targets = (payload.Targets)[1:]
 				})
-				*request = (*request).UpdateTargetPoolPayload(*payload)
+				*request = request.UpdateTargetPoolPayload(*payload)
 			}),
 		},
 		{

internal/pkg/services/load-balancer/utils/utils_test.go

@@ -44,7 +44,6 @@ func newAPIMock(s mockSettings) loadbalancer.DefaultAPI {
 		}),
 		GetLoadBalancerExecuteMock: utils.Ptr(func(_ loadbalancer.ApiGetLoadBalancerRequest) (*loadbalancer.LoadBalancer, error) {
 			if s.getLoadBalancerFails {
-
 				return nil, fmt.Errorf("could not get load balancer")
 			}
 			return s.getLoadBalancerResp, nil