Skip to content

Add tests to the library #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoseLion opened this issue Aug 18, 2020 · 0 comments · Fixed by #12
Closed

Add tests to the library #4

JoseLion opened this issue Aug 18, 2020 · 0 comments · Fixed by #12
Labels
enhancement New feature or request

Comments

@JoseLion
Copy link
Member

This library came from another project and the tests it used to have were highly coupled to that specific project. We'd like to add test to the library taking into account the following points:

  • Integration tests might be challenging since we're declaring the core libraries as peer dependencies (react, react-native, react-native-svg), so they will not be actually installed
  • One of the core features of the library relies on measuring the layout of components across the screen. However, this is not possible in the context of an integration test because the components are never actually rendered, therefore measurements will always be undefined
@JoseLion JoseLion added the enhancement New feature or request label Aug 18, 2020
@JoseLion JoseLion changed the title Add tests where possible Add tests to the library Aug 18, 2020
@ChristianMarca ChristianMarca linked a pull request Sep 4, 2020 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants