Skip to content

Resizing Terminal is buggy because of the iframe #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GaetanRouzies opened this issue Mar 20, 2025 · 0 comments
Open

Resizing Terminal is buggy because of the iframe #441

GaetanRouzies opened this issue Mar 20, 2025 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers pr-welcome Accepting pull requests for this change

Comments

@GaetanRouzies
Copy link

GaetanRouzies commented Mar 20, 2025

Describe the bug

The Terminal is not resizing correctly.

Link to a StackBlitz project which shows the error

https://demo.tutorialkit.dev/

Steps to reproduce

  1. Go to TutorialKit Demo
  2. Toggle the Terminal
  3. Try to resize the Terminal
  4. Sometime the resizing doesn't happens or is stuck

Expected behavior

The Terminal should resizing correctly.

Screenshots

Here's a video to show the bug

CleanShot.2025-03-20.at.10.40.15.mp4

Platform

  • TutorialKit version: Demo
  • OS: macOS
  • Browser: Chromium (Brave)
  • Version: 1.76

Additional context

I had this problem while making my own iframe and Terminal with panels I can resize. I fixed it by putting an overlay on the iframe when resizing. I think it’s because the iframe’s resize and mouse events stop the Terminal panel from resizing right.

@AriPerkkio AriPerkkio added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed pr-welcome Accepting pull requests for this change and removed help wanted Extra attention is needed labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers pr-welcome Accepting pull requests for this change
Projects
None yet
Development

No branches or pull requests

2 participants