Skip to content

Commit 8aaf2cf

Browse files
authored
fix(stackable-telemetry): Only derive clap::ValueEnum if the clap feature is enabled (#1026)
* fix(stackable-telemetry): Only derive clap::ValueEnum if the clap feature is enabled * chore(stackable-telemetry): Update changelog
1 parent d62914b commit 8aaf2cf

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

crates/stackable-telemetry/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,12 @@ All notable changes to this project will be documented in this file.
88

99
- Bump `opentelemetry` and related crates to `0.29.x` and `tracing-opentelemetry` to `0.30.0` ([#1021]).
1010

11+
### Fixed
12+
13+
- Only derive `clap::ValueEnum` if the `clap` feature is enabled ([#1026]).
14+
1115
[#1021]: https://github.com/stackabletech/operator-rs/pull/1021
16+
[#1026]: https://github.com/stackabletech/operator-rs/pull/1026
1217

1318
## [0.6.0] - 2025-04-14
1419

crates/stackable-telemetry/src/tracing/settings/console_log.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@ pub enum ConsoleLogSettings {
2424
/// Console subscriber log event output formats.
2525
///
2626
/// Currently, only [Plain][Format::Plain] is supported.
27-
#[derive(
28-
Clone, Debug, Default, Eq, PartialEq, strum::EnumString, strum::Display, clap::ValueEnum,
29-
)]
27+
#[derive(Clone, Debug, Default, Eq, PartialEq, strum::EnumString, strum::Display)]
28+
#[cfg_attr(feature = "clap", derive(clap::ValueEnum))]
3029
#[strum(serialize_all = "snake_case")]
3130
pub enum Format {
3231
/// Use the plain unstructured log output.

0 commit comments

Comments
 (0)