Merge #337

337: Truncate events to the actual length limit, rather than a constant amount r=teozkr a=teozkr

## Description

## Review Checklist
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added (or not applicable)
- [ ] Documentation added (or not applicable)
- [ ] Changelog updated (or not applicable)


Co-authored-by: Teo Klestrup Röijezon <[email protected]>

Author: bors[bot]

CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+### Fixed
+
+- Truncate k8s event strings correctly, when required ([#337]).
+
+[#337]: https://github.com/stackabletech/operator-rs/pull/337
+
 ## [0.13.0] - 2022-02-23
 
 ### Added

src/logging/k8s_events.rs

@@ -87,11 +87,13 @@ mod message {
         const ELLIPSIS_LEN: usize = ELLIPSIS.len_utf8();
         let len = msg.len();
         if len > max_len {
-            msg.truncate(find_start_of_char(msg, len.saturating_sub(ELLIPSIS_LEN)));
+            let start_of_trunc_char = find_start_of_char(msg, max_len.saturating_sub(ELLIPSIS_LEN));
+            msg.truncate(start_of_trunc_char);
             if ELLIPSIS_LEN <= max_len {
                 msg.push(ELLIPSIS);
             }
         }
+        debug_assert!(msg.len() <= max_len);
     }
 
     fn find_start_of_char(s: &str, mut pos: usize) -> usize {
@@ -120,7 +122,10 @@ mod message {
         fn truncate_should_ellipsize_large_string() {
             let mut x = "hello".to_string();
             truncate_with_ellipsis(&mut x, 4);
-            assert_eq!(&x, "he…");
+            assert_eq!(&x, "h…");
+            x = "hello, this is a much larger string".to_string();
+            truncate_with_ellipsis(&mut x, 4);
+            assert_eq!(&x, "h…");
         }
 
         #[test]