-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we add eslint and prettier #8
Comments
I think those are "developers choice" and it's better if this project is not opinionated in that way? |
Yeah I agree |
@jayair However, there does appear to be a problem when adding providers to the base template: ❯ sst add pulumi
⠸ Adding provider...error: Cannot find package "prettier" from "[project]/.sst/platform/src/ast/add.ts" |
❯ sst add pulumi --print-logs
time=2024-11-02T08:51:57.531-07:00 level=INFO msg="checking for pulumi" path="[redacted]/Library/Application Support/sst/bin/pulumi"
time=2024-11-02T08:51:57.808-07:00 level=INFO msg="checking for bun" path="[redacted]/Library/Application Support/sst/bin/bun"
⠋ Adding provider...time=2024-11-02T08:51:57.834-07:00 level=INFO msg="esbuild building" out=[redacted]/.sst/platform/sst.config.1730562717833.mjs
time=2024-11-02T08:51:57.843-07:00 level=INFO msg="esbuild built" outfile=[redacted]/.sst/platform/sst.config.1730562717833.mjs
time=2024-11-02T08:51:57.844-07:00 level=INFO msg="evaluating config"
time=2024-11-02T08:51:57.876-07:00 level=INFO msg="config evaluated"
time=2024-11-02T08:51:57.877-07:00 level=INFO msg="checking platform"
time=2024-11-02T08:51:57.877-07:00 level=INFO msg="getting package" name=@sst-provider/pulumi version=latest
⠸ Adding provider...error: Cannot find package "prettier" from "[redacted]/.sst/platform/src/ast/add.ts" To fix I had to cd into But, that's not all. This is the output now: ❯ sst add pulumi
✓ Added provider "supabase". You can create resources with `new supabase.SomeResource()` Hmm. |
Actually, I realize that However, it did add an entry to my providers: { pulumi: "0.0.2" } |
Hmm yeah that's weird. We should handle invalid providers better. |
It would be helpful to have this template with eslint and prettier already setup
The text was updated successfully, but these errors were encountered: