Skip to content

Commit dea3f23

Browse files
committed
Merge branch 'develop'
2 parents 4e0b343 + c4f6021 commit dea3f23

24 files changed

+219
-439
lines changed

.travis.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ dist: trusty
22
sudo: false
33
language: node_js
44
node_js:
5-
- 6.9.4
5+
- 6.9.5
66
addons:
77
apt:
88
sources:

CHANGELOG.md

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Change Log
2+
All notable changes to this project will be documented in this file.
3+
4+
The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
5+
6+
## [Unreleased]
7+
8+
## [1.0.0] - 2017-02-05
9+
- First official release.
10+
11+
[Unreleased]: https://github.com/ssoloff/dice-server-js/compare/v1.0.0...HEAD

README.md

+18-4
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,31 @@
1-
# dice-server-js
1+
# Dice Server JS
22

33
[![Build Status][travis-image]][travis-link]
44
[![Coverage Status][coveralls-image]][coveralls-link]
5-
[![Node Dependency Status][david-image]][david-link]
6-
[![Node Dev Dependency Status][david-dev-image]][david-dev-link]
5+
[![Dependency Status][david-image]][david-link]
6+
[![Dev Dependency Status][david-dev-image]][david-dev-link]
77

8-
Server for parsing and executing dice notation.
8+
A server for parsing and evaluating dice notation.
9+
10+
## Usage
11+
12+
* Stable version: https://dice-server-js.herokuapp.com
13+
* Latest development version: https://dice-server-js-staging.herokuapp.com
14+
15+
DSJS provides a basic client for evaluating standard dice notation. Instructions for using this client, as well as the supported dice notation grammar, are available on the [wiki](https://github.com/ssoloff/dice-server-js/wiki/Client-help).
16+
17+
DSJS also provides an [API](https://github.com/ssoloff/dice-server-js/wiki/API) that can be used by third parties to implement a secure dice rolling service between game masters and players.
18+
19+
## License
20+
21+
Licensed under the terms of the [MIT License][license-link].
922

1023
[coveralls-image]: https://coveralls.io/repos/ssoloff/dice-server-js/badge.svg?branch=master&service=github
1124
[coveralls-link]: https://coveralls.io/github/ssoloff/dice-server-js?branch=master
1225
[david-image]: https://david-dm.org/ssoloff/dice-server-js.svg
1326
[david-link]: https://david-dm.org/ssoloff/dice-server-js
1427
[david-dev-image]: https://david-dm.org/ssoloff/dice-server-js/dev-status.svg
1528
[david-dev-link]: https://david-dm.org/ssoloff/dice-server-js#info=devDependencies
29+
[license-link]: https://opensource.org/licenses/MIT
1630
[travis-image]: https://travis-ci.org/ssoloff/dice-server-js.svg?branch=master
1731
[travis-link]: https://travis-ci.org/ssoloff/dice-server-js

features/client/support/home-page.js

+1-18
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ const Locators = {
4040

4141
expressionText: () => By.id('main-eval-expressionText'),
4242

43-
help: () => By.id('main-eval-help'),
44-
4543
randomNumberGeneratorJson: () => By.id('main-eval-randomNumberGeneratorJson'),
4644

4745
reevaluateExpressionResult: () => By.name('reevaluate'),
@@ -52,9 +50,7 @@ const Locators = {
5250

5351
requestId: () => By.id('main-eval-requestId'),
5452

55-
roundingMode: (roundingMode) => By.id(`main-eval-roundingMode${roundingMode}`),
56-
57-
toggleHelp: () => By.id('main-eval-toggleHelp')
53+
roundingMode: (roundingMode) => By.id(`main-eval-roundingMode${roundingMode}`)
5854
}
5955

6056
class HomePage {
@@ -106,18 +102,10 @@ class HomePage {
106102
.getText()
107103
}
108104

109-
getHelpLinkText () {
110-
return this.driver.findElement(Locators.toggleHelp()).getText()
111-
}
112-
113105
isErrorMessageDisplayed () {
114106
return this.driver.findElement(Locators.errorMessage()).isDisplayed()
115107
}
116108

117-
isHelpDisplayed () {
118-
return this.driver.findElement(Locators.help()).isDisplayed()
119-
}
120-
121109
open () {
122110
return this.driver.get(`${config.baseUri}/`)
123111
}
@@ -156,11 +144,6 @@ class HomePage {
156144
return this.driver.findElement(Locators.roundingMode(roundingMode)).click()
157145
}
158146

159-
toggleHelp () {
160-
return this._wait(until.elementsLocated(Locators.toggleHelp()))
161-
.then((elements) => elements[0].click())
162-
}
163-
164147
typeEnter () {
165148
return this.typeExpressionText(Key.ENTER)
166149
}

features/client/ui/offering_help.feature

-26
This file was deleted.

features/client/ui/step_definitions/steps.js

-19
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@ module.exports = function () {
5353
}
5454
)
5555

56-
this.When(/^the(?: hide)? help link is clicked$/, function () {
57-
return this.homePage.toggleHelp()
58-
})
59-
6056
this.When(/^the reevaluate button on the (\d+)(?:st|nd|rd|th) row is clicked$/, function (row) {
6157
this.resultRowCount += 1
6258
return this.homePage.reevaluateResultAtRow(row)
@@ -92,14 +88,6 @@ module.exports = function () {
9288
)
9389
})
9490

95-
this.Then(/^help should( not)? be displayed$/, function (shouldNotBeDisplayed) {
96-
const shouldBeDisplayed = !shouldNotBeDisplayed
97-
return this.homePage.awaitUntil(() =>
98-
this.homePage.isHelpDisplayed()
99-
.then((displayed) => expect(displayed).to.be[shouldBeDisplayed ? 'true' : 'false'])
100-
)
101-
})
102-
10391
this.Then(
10492
/^the(?: (\d+)(?:st|nd|rd|th))? expression canonical text should be "(.*)"$/,
10593
function (row, expressionCanonicalText) {
@@ -137,13 +125,6 @@ module.exports = function () {
137125
}
138126
)
139127

140-
this.Then(/^the help link text should be "(.*)"$/, function (helpLinkText) {
141-
return this.homePage.awaitUntil(() =>
142-
this.homePage.getHelpLinkText()
143-
.then((text) => expect(text).to.equal(helpLinkText))
144-
)
145-
})
146-
147128
this.Then(/^the results table should be empty$/, function () {
148129
return this.homePage.awaitUntil(() =>
149130
this.homePage.getExpressionResultCount()

0 commit comments

Comments
 (0)