@@ -53,7 +53,6 @@ Note that code issues should be filed against the
53
53
[ individual Knative repositories] ( http://github.com/knative ) , while
54
54
documentation issues should go in the ` docs ` repository.
55
55
56
-
57
56
### Working group
58
57
59
58
The [ Knative Documentation Working Group] ( ./WORKING-GROUPS.md#documentation )
@@ -112,8 +111,8 @@ that are only expected to be used by contributors, those samples are put in the
112
111
## Docs contributor roles
113
112
114
113
Because contributing to the documentation requires a different skill set than
115
- contributing to the Knative code base, we've defined the roles of
116
- documentation contributors seperately from the roles of code contributors.
114
+ contributing to the Knative code base, we've defined the roles of documentation
115
+ contributors seperately from the roles of code contributors.
117
116
118
117
If you're looking for code contributor roles, see [ ROLES] ( ./ROLES.md ) .
119
118
@@ -122,21 +121,21 @@ If you're looking for code contributor roles, see [ROLES](./ROLES.md).
122
121
Established contributor to the Knative docs.
123
122
124
123
Members are continuously active contributors in the community. They can have
125
- issues and PRs assigned to them, might participate in working group meetings, and
126
- pre-submit tests are automatically run for their PRs. Members are expected to
127
- remain active contributors to the Knative documentation.
124
+ issues and PRs assigned to them, might participate in working group meetings,
125
+ and pre-submit tests are automatically run for their PRs. Members are expected
126
+ to remain active contributors to the Knative documentation.
128
127
129
- All members are encouraged to help with PR reviews, although each PR
130
- must be reviewed by an official [ Approver] ( #approver ) . In their review,
131
- members should be looking for technical correctness of the documentation,
132
- adherence to the [ style guide] ( https://developers.google.com/style/ ) , good spelling and grammar (writing quality),
133
- intuitive organization, and strong documentation usability. Members should be
134
- proficient in at least one of these review areas.
128
+ All members are encouraged to help with PR reviews, although each PR must be
129
+ reviewed by an official [ Approver] ( #approver ) . In their review, members should
130
+ be looking for technical correctness of the documentation, adherence to the
131
+ [ style guide] ( https://developers.google.com/style/ ) , good spelling and grammar
132
+ (writing quality), intuitive organization, and strong documentation usability.
133
+ Members should be proficient in at least one of these review areas.
135
134
136
135
### Requirements
137
136
138
- - Has made multiple contributions to the project or community. Contributions might
139
- include, but are not limited to:
137
+ - Has made multiple contributions to the project or community. Contributions
138
+ might include, but are not limited to:
140
139
141
140
- Authoring and reviewing PRs on GitHub in the Docs or Website repos.
142
141
@@ -157,42 +156,45 @@ proficient in at least one of these review areas.
157
156
158
157
- Responsive to issues and PRs assigned to them.
159
158
160
- - Active owner of documents they have contributed (unless ownership is explicitly
161
- transferred).
162
-
159
+ - Active owner of documents they have contributed (unless ownership is
160
+ explicitly transferred).
161
+
163
162
- Addresses bugs or issues in their documentation in a timely manner.
164
-
163
+
165
164
### Becoming a member
166
165
167
- First, reach out to an approver and ask them to sponsor you so that you can become a member.
168
- The easiest way to do this is using Slack.
166
+ First, reach out to an approver and ask them to sponsor you so that you can
167
+ become a member. The easiest way to do this is using Slack.
169
168
170
- If they are supportive of your membership, your sponsor will reach out to the Knative Steering
171
- committee to ask that you be added as a member of the Knative org.
169
+ If they are supportive of your membership, your sponsor will reach out to the
170
+ Knative Steering committee to ask that you be added as a member of the Knative
171
+ org.
172
+
173
+ Once your sponsor notifies you that you've been added to the Knative org, open a
174
+ PR to add yourself as a docs-reviewer in the [ OWNERS_ALIASES] ( ../OWNERS_ALIASES )
175
+ file.
172
176
173
- Once your sponsor notifies you that you've been added to the Knative org,
174
- open a PR to add yourself as a docs-reviewer in the
175
- [ OWNERS_ALIASES] ( ../OWNERS_ALIASES ) file.
176
-
177
177
## Approver
178
178
179
179
Docs approvers are able to both review and approve documentation contributions.
180
180
While documentation review is focused on writing quality and correctness,
181
181
approval is focused on holistic acceptance of a contribution including:
182
- long-term maintainability, adhering to style guide conventions, overall information
183
- architecture, and usability from an engineering standpoint. Docs approvers will
184
- enlist help from engineers for reviewing code-heavy contributions to the Docs repo.
182
+ long-term maintainability, adhering to style guide conventions, overall
183
+ information architecture, and usability from an engineering standpoint. Docs
184
+ approvers will enlist help from engineers for reviewing code-heavy contributions
185
+ to the Docs repo.
185
186
186
187
### Requirements
187
188
188
189
- Reviewer of the Docs repo for at least 3 months.
189
-
190
- - Proficient in reviewing all aspects of writing quality, including grammar and
191
- spelling, adherence to style guide conventions, organization, and usability.
192
- Can coach newer writers to improve their contributions in these areas.
193
-
194
- - Primary reviewer for at least 10 substantial PRs to the docs, showing substantial
195
- ability to coach for writing development.
190
+
191
+ - Proficient in reviewing all aspects of writing quality, including grammar
192
+ and spelling, adherence to style guide conventions, organization, and
193
+ usability. Can coach newer writers to improve their contributions in these
194
+ areas.
195
+
196
+ - Primary reviewer for at least 10 substantial PRs to the docs, showing
197
+ substantial ability to coach for writing development.
196
198
197
199
- Reviewed or merged at least 30 PRs to the docs.
198
200
@@ -204,9 +206,9 @@ enlist help from engineers for reviewing code-heavy contributions to the Docs re
204
206
205
207
- Responsible for documentation quality control via PR reviews.
206
208
207
- - Focus on long-term maintainability, adhering to style
208
- guide conventions, overall information architecture, and usability from
209
- an engineering standpoint.
209
+ - Focus on long-term maintainability, adhering to style guide conventions,
210
+ overall information architecture, and usability from an engineering
211
+ standpoint.
210
212
211
213
- Expected to be responsive to review requests as per
212
214
[ community expectations] ( REVIEWING.md ) .
@@ -218,12 +220,11 @@ enlist help from engineers for reviewing code-heavy contributions to the Docs re
218
220
219
221
### Becoming an approver
220
222
221
- If you want to become an approver, make your goal clear to the current
222
- Knative Docs approvers, either by contacting them in Slack or announcing
223
- your intention to become an approver at a meeting of the Documentation
224
- Working Group.
223
+ If you want to become an approver, make your goal clear to the current Knative
224
+ Docs approvers, either by contacting them in Slack or announcing your intention
225
+ to become an approver at a meeting of the Documentation Working Group.
225
226
226
- Once you feel you meet the criteria, you can ask one of the current
227
- approvers to nominate you to become an approver. If all existing
228
- approvers agree that you meet the criteria open a PR to add yourself
229
- as a docs-approver in the [ OWNERS_ALIASES] ( ../OWNERS_ALIASES ) file.
227
+ Once you feel you meet the criteria, you can ask one of the current approvers to
228
+ nominate you to become an approver. If all existing approvers agree that you
229
+ meet the criteria open a PR to add yourself as a docs-approver in the
230
+ [ OWNERS_ALIASES] ( ../OWNERS_ALIASES ) file.
0 commit comments