Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Simplify the validity joins with dplyr::join_by. #169

Open
RasmusSkytte opened this issue Oct 11, 2024 · 0 comments
Open

FEATURE: Simplify the validity joins with dplyr::join_by. #169

RasmusSkytte opened this issue Oct 11, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@RasmusSkytte
Copy link
Contributor

RasmusSkytte commented Oct 11, 2024

Describe the feature
When filtering the validity periods in diseasystore, we often have to copy the dates to the remote connection and then filter using an inner_join with an sql_on argument.

This syntax is more confusing than the new dplyr::join_by() syntax for the corresponding joins.

An example of the bad syntax can be seen in the simulist_age FeatureHandler in #162 which is confusing for the user.

SCDB has a pull request open for allowing dplyr::join_by() in its joins (ssi-dk/SCDB#156)
Once released, we should implement in diseasystore to simplify the code

What use will this feature have?
Improved readability. Easier implementation of new diseasystores.

Who should add the feature?
N/A

Additional context
N/A

@RasmusSkytte RasmusSkytte added the enhancement New feature or request label Oct 11, 2024
@RasmusSkytte RasmusSkytte added this to the v0.4 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant