Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "short" names for components #438

Open
smacker opened this issue Apr 12, 2019 · 2 comments
Open

Use "short" names for components #438

smacker opened this issue Apr 12, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@smacker
Copy link
Contributor

smacker commented Apr 12, 2019

We have at least components install and components start commands which expect name of a component. Currently, it works only with srcd-cli-<name>.
There are at least 2 solutions:

  • add prefix automatically in that commands
  • update components to expose name without the prefix
  • ???
@smacker smacker mentioned this issue Apr 12, 2019
Merged
@dpordomingo
Copy link
Contributor

I'd try to decouple the implementation details: image and container names, from the user facing. Considering that, the second option looks more aligned with that goal.

@carlosms carlosms added the enhancement New feature or request label Apr 16, 2019
@se7entyse7en
Copy link
Contributor

I agree with @dpordomingo. I prefer the second option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smacker @carlosms @dpordomingo @se7entyse7en