Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use icmd to test interactive SQL REPL #412

Open
se7entyse7en opened this issue Apr 5, 2019 · 2 comments
Open

Use icmd to test interactive SQL REPL #412

se7entyse7en opened this issue Apr 5, 2019 · 2 comments

Comments

@se7entyse7en
Copy link
Contributor

Current the test of interactive SQL REPL doesn't use icmd, but it uses os/exec directly.

Context here.
@se7entyse7en se7entyse7en mentioned this issue Apr 5, 2019
Merged
@smacker
Copy link
Contributor

smacker commented Apr 5, 2019

I don't see any problem with testing repl without icmd. This test is clearly different from others and I'm not sure such use case will be ever supported by icmd project.

@se7entyse7en
Copy link
Contributor Author

This test is clearly different from others

True, I just think that in case we're able to use icmd even in this case we have more consistency as we would have a single api for running commands. I haven't tried patching it locally, but it should be easy to try it and eventually open a PR to icmd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smacker @se7entyse7en