Skip to content

Commit d88ff86

Browse files
committed
Modified Makefile and test in order to possibly test a different next version
Signed-off-by: Lou Marvin Caraig <[email protected]>
1 parent f25f037 commit d88ff86

File tree

2 files changed

+29
-5
lines changed

2 files changed

+29
-5
lines changed

Makefile

+27-4
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,16 @@ $(MAKEFILE):
1818
GOTEST_INTEGRATION = $(GOTEST) -parallel 1 -count 1 -tags=integration -ldflags "$(LD_FLAGS)"
1919

2020
OS := $(shell uname)
21+
CURRENT_BUILD_PATH := $(BUILD_PATH)
2122
PREV_BUILD_PATH := build-prev
23+
NEXT_BUILD_PATH := build-next
2224

23-
CURRENT_VERSION := $(shell git rev-parse --abbrev-ref HEAD)
25+
CURRENT_VERSION := $(shell git rev-parse HEAD)
26+
27+
# Latest non release candidate version
2428
PREV_VERSION ?= $(shell git describe --abbrev=0 --tags --exclude "*-rc*")
29+
# Current commit
30+
NEXT_VERSION ?= $(CURRENT_VERSION)
2531

2632
# Targets for integration testing
2733
integration-clean-previous:
@@ -34,12 +40,29 @@ integration-build-previous: integration-clean-previous integration-prepare-build
3440
git checkout -q $(CURRENT_VERSION)
3541
echo "Built version $(PREV_VERSION)"
3642

37-
integration-clean-current: clean
38-
integration-build-current: integration-clean-current build docker-build
39-
echo "Built current version"
43+
integration-clean-next:
44+
rm -rf $(NEXT_BUILD_PATH)
45+
$(GOCLEAN) .
46+
integration-prepare-build-next:
47+
git checkout -q $(NEXT_VERSION)
48+
$(eval BUILD_PATH = $(NEXT_BUILD_PATH))
49+
integration-build-next: integration-clean-next integration-prepare-build-next build docker-build
50+
git checkout -q $(CURRENT_VERSION)
51+
echo "Built version $(NEXT_VERSION)"
52+
53+
integration-clean-current:
54+
rm -rf $(CURRENT_BUILD_PATH)
55+
$(GOCLEAN) .
56+
integration-prepare-build-current:
57+
git checkout -q $(CURRENT_VERSION)
58+
$(eval BUILD_PATH = $(CURRENT_BUILD_PATH))
59+
integration-build-current: integration-clean-current integration-prepare-build-current build docker-build
60+
git checkout -q $(CURRENT_VERSION)
61+
echo "Built version $(CURRENT_VERSION)"
4062

4163
integration-build-all:
4264
$(MAKE) integration-build-current
65+
$(MAKE) integration-build-next
4366
$(MAKE) integration-build-previous
4467

4568
ifeq ($(OS),Darwin)

cmd/test-utils/common.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import (
1919
// TODO (carlosms) this could be build/bin, workaround for https://github.com/src-d/ci/issues/97
2020
var srcdBin = fmt.Sprintf("../../../build/engine_%s_%s/srcd", runtime.GOOS, runtime.GOARCH)
2121
var srcdPrevBin = fmt.Sprintf("../../../build-prev/engine_%s_%s/srcd", runtime.GOOS, runtime.GOARCH)
22+
var srcdNextBin = fmt.Sprintf("../../../build-next/engine_%s_%s/srcd", runtime.GOOS, runtime.GOARCH)
2223
var configFile = "../../../integration-testing-config.yaml"
2324

2425
func init() {
@@ -66,7 +67,7 @@ type IntegrationBackCompSuite struct {
6667

6768
func NewIntegrationBackCompSuite() IntegrationBackCompSuite {
6869
return IntegrationBackCompSuite{
69-
IntegrationSuite: NewIntegrationSuite(),
70+
IntegrationSuite: IntegrationSuite{Cmd: &Commander{bin: srcdNextBin}},
7071
PrevCmd: &Commander{bin: srcdPrevBin},
7172
}
7273
}

0 commit comments

Comments
 (0)