Added test that the index is really being used

Signed-off-by: Lou Marvin Caraig <[email protected]>

Author: se7entyse7en

cmd/srcd/cmd/gitbase_back_comp_test.go

@@ -13,6 +13,7 @@ import (
 	"path/filepath"
 	"regexp"
 	"runtime"
+	"strings"
 	"testing"
 	"time"
 
@@ -200,7 +201,7 @@ func (s *GitbaseBackCompTestSuite) TestRetroCompatibleIndexes() {
 	require.NoError(err)
 
 	// [previous version] srcd sql "select * from repositories"
-	buf, err := s.runSQL(s.PrevCmd, "select * from repositories")
+	buf, err := s.runSQL(s.PrevCmd, "SELECT * FROM repositories")
 	require.NoError(err)
 
 	expected := `+---------------+
@@ -240,27 +241,21 @@ func (s *GitbaseBackCompTestSuite) TestRetroCompatibleIndexes() {
 `
 	require.NoError(cmdtest.AreSQLOutputEqual(buf.String(), expected))
 
-	// [previous version] srcd sql "select * from repositories"
-	buf, err = s.runSQL(s.PrevCmd, "select * from repositories")
+	// [previous version] srcd sql "explain select * from repositories"
+	buf, err = s.runSQL(s.PrevCmd, "EXPLAIN FORMAT=tree SELECT * FROM repositories WHERE repository_id='repo-0'")
 	require.NoError(err)
+	require.Contains(strings.ToUpper(buf.String()), "INDEXES")
+	require.Contains(buf.String(), "repo_idx")
 
-	expected = `+---------------+
-| REPOSITORY ID |
-+---------------+
-| repo-0        |
-| repo-1        |
-| repo-2        |
-+---------------+`
-	require.NoError(cmdtest.AreSQLOutputEqual(buf.String(), expected))
-
+	// [previous version] srcd stop
 	s.PrevCmd.RunStop(context.Background())
 
 	// [current version] srcd init s.testDir
 	_, err = s.runInit(s.CurrCmd, s.testDir)
 	require.NoError(err)
 
 	// [current version] srcd sql "select * from repositories"
-	buf, err = s.runSQL(s.CurrCmd, "select * from repositories")
+	buf, err = s.runSQL(s.CurrCmd, "SELECT * FROM repositories")
 	require.NoError(err)
 
 	expected = `+---------------+
@@ -283,6 +278,12 @@ func (s *GitbaseBackCompTestSuite) TestRetroCompatibleIndexes() {
 `
 	require.NoError(cmdtest.AreSQLOutputEqual(buf.String(), expected))
 
+	// [current version] srcd sql "explain select * from repositories"
+	buf, err = s.runSQL(s.CurrCmd, "EXPLAIN FORMAT=tree SELECT * FROM repositories WHERE repository_id='repo-0'")
+	require.NoError(err)
+	require.Contains(strings.ToUpper(buf.String()), "INDEXES")
+	require.Contains(buf.String(), "repo_idx")
+
 	// [current version] srcd sql "DROP INDEXES"
 	_, err = s.runSQL(s.CurrCmd, "DROP INDEX repo_idx ON repositories")
 	require.NoError(err)
@@ -297,16 +298,9 @@ func (s *GitbaseBackCompTestSuite) TestRetroCompatibleIndexes() {
 `
 	require.NoError(cmdtest.AreSQLOutputEqual(buf.String(), expected))
 
-	// [current version] srcd sql "select * from repositories"
-	buf, err = s.runSQL(s.CurrCmd, "select * from repositories")
+	// [current version] srcd sql "explain select * from repositories"
+	buf, err = s.runSQL(s.CurrCmd, "EXPLAIN FORMAT=tree SELECT * FROM repositories")
 	require.NoError(err)
-
-	expected = `+---------------+
-| REPOSITORY ID |
-+---------------+
-| repo-0        |
-| repo-1        |
-| repo-2        |
-+---------------+`
-	require.NoError(cmdtest.AreSQLOutputEqual(buf.String(), expected))
+	require.NotContains(strings.ToUpper(buf.String()), "INDEXES")
+	require.NotContains(buf.String(), "repo_idx")
 }