Additional fix for #2506

Slightly different fix for the second code snippet reported there. Uses startOfStatement instead of line unless it detects method chaining.

Author: gsherwood

src/Standards/PEAR/Sniffs/Functions/FunctionCallSignatureSniff.php

@@ -339,13 +339,11 @@ public function processMultiLineCall(File $phpcsFile, $stackPtr, $openBracket, $
         // call itself is, so we can work out how far to
         // indent the arguments.
         $first = $phpcsFile->findFirstOnLine(T_WHITESPACE, $stackPtr, true);
-        if ($tokens[$first]['code'] === T_CONSTANT_ENCAPSED_STRING
-            && $tokens[($first - 1)]['code'] === T_CONSTANT_ENCAPSED_STRING
-        ) {
-            // We are in a multi-line string, so find the start and use
-            // the indent from there.
-            $prev  = $phpcsFile->findPrevious(T_CONSTANT_ENCAPSED_STRING, ($first - 2), null, true);
-            $first = $phpcsFile->findFirstOnLine(Tokens::$emptyTokens, $prev, true);
+        if ($tokens[$first]['code'] !== T_OBJECT_OPERATOR) {
+            // This is not a chained method, so go back and look for the
+            // start of the statement and take our indent from there.
+            $start = $phpcsFile->findStartOfStatement($stackPtr, true);
+            $first = $phpcsFile->findFirstOnLine(T_WHITESPACE, $start, true);
         }
 
         $foundFunctionIndent = 0;

src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc

@@ -442,3 +442,18 @@ function m()
             ) . '
     ' : '');
 }
+
+class C
+{
+
+    public function m()
+    {
+        $a = [];
+        $t =
+            "SELECT * FROM t
+WHERE f IN(" . implode(
+                ",",
+                $a
+            ) . ")";
+    }
+}

src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.inc.fixed

@@ -452,3 +452,18 @@ function m()
     ) . '
     ' : '');
 }
+
+class C
+{
+
+    public function m()
+    {
+        $a = [];
+        $t =
+            "SELECT * FROM t
+WHERE f IN(" . implode(
+            ",",
+            $a
+        ) . ")";
+    }
+}

src/Standards/PEAR/Tests/Functions/FunctionCallSignatureUnitTest.php

@@ -119,6 +119,9 @@ public function getErrorList($testFile='FunctionCallSignatureUnitTest.inc')
             440 => 1,
             441 => 1,
             442 => 1,
+            455 => 1,
+            456 => 1,
+            457 => 1,
         ];
 
     }//end getErrorList()