Invalid exclude rules inside a ruleset.xml file are now ignored instead of potentially causing out of memory errors

Author: gsherwood

package.xml

@@ -29,6 +29,8 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - The indent property of PEAR.Classes.ClassDeclaration has been removed
     -- Instead of calculating the indent of the brace, it just ensures the brace is aligned with the class keyword
     -- Other sniffs can be used to ensure the class itself is indented correctly
+  - Invalid exclude rules inside a ruleset.xml file are now ignored instead of potentially causing out of memory errors
+    -- Using the -vv command line argument now also shows the invalid exclude rule as XML
   - Includes all changes from the 2.8.1 release
   - Fixed bug #1333 : The new autoloader breaks some frameworks with custom autoloaders
   - Fixed bug #1334 : Undefined offset when explaining standard with custom sniffs

src/Ruleset.php

@@ -372,6 +372,16 @@ public function processRuleset($rulesetPath, $depth=0)
 
             if (isset($rule->exclude) === true) {
                 foreach ($rule->exclude as $exclude) {
+                    if (isset($exclude['name']) === false) {
+                        if (PHP_CODESNIFFER_VERBOSITY > 1) {
+                            echo str_repeat("\t", $depth);
+                            echo "\t\t* ignoring empty exclude rule *".PHP_EOL;
+                            echo "\t\t\t=> ".$exclude->asXML().PHP_EOL;
+                        }
+
+                        continue;
+                    }
+
                     if ($this->shouldProcessElement($exclude) === false) {
                         continue;
                     }