Escape the notify-send path when getting the version number

gsherwood · gsherwood · commit 254ced69163e · 2017-02-28T08:47:39.000+11:00
diff --git a/CodeSniffer/Reports/Notifysend.php b/CodeSniffer/Reports/Notifysend.php
@@ -82,7 +82,7 @@ public function __construct()
     {
         $path = PHP_CodeSniffer::getConfigData('notifysend_path');
         if ($path !== null) {
-            $this->path = $path;
+            $this->path = escapeshellcmd($path);
         }
 
         $timeout = PHP_CodeSniffer::getConfigData('notifysend_timeout');
@@ -246,7 +246,7 @@ protected function notifyErrors($msg)
      */
     protected function getBasicCommand()
     {
-        $cmd  = escapeshellcmd($this->path);
+        $cmd  = $this->path;
         $cmd .= ' --category dev.validate';
         $cmd .= ' -h int:transient:1';
         $cmd .= ' -t '.(int) $this->timeout;

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public function __construct()`
`82`	`82`	`{`
`83`	`83`	`$path = PHP_CodeSniffer::getConfigData('notifysend_path');`
`84`	`84`	`if ($path !== null) {`
`85`		`- $this->path = $path;`
	`85`	`+ $this->path = escapeshellcmd($path);`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`$timeout = PHP_CodeSniffer::getConfigData('notifysend_timeout');`
`@@ -246,7 +246,7 @@ protected function notifyErrors($msg)`
`246`	`246`	`*/`
`247`	`247`	`protected function getBasicCommand()`
`248`	`248`	`{`
`249`		`- $cmd = escapeshellcmd($this->path);`
	`249`	`+ $cmd = $this->path;`
`250`	`250`	`$cmd .= ' --category dev.validate';`
`251`	`251`	`$cmd .= ' -h int:transient:1';`
`252`	`252`	`$cmd .= ' -t '.(int) $this->timeout;`