Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modrinth doesn't allow client side: required with server side: optional #288

Open
dhouck opened this issue Feb 6, 2024 · 4 comments
Open
Labels
upstream Specific to something that this mod relies on

Comments

@dhouck
Copy link

dhouck commented Feb 6, 2024

Currently, Modrinth reports that this mod is unsupported on servers. Unless there have been some big changes since I last checked, this is incorrect; the Modrinth metadata should be updated to say itʼs optional for servers and required for clients.

(Alternately, if the metadata is correct, the description is out of date as it recommends installing on the server too)

Edit: add screenshot
image

@squeek502
Copy link
Owner

Thanks, fixed. Not sure what happened as it was set to optional before, see #275

@dhouck
Copy link
Author

dhouck commented Feb 7, 2024

Iʼm still seeing it as unsupported; is that sometimes slow to propagate, or will it only take effect with a new version?

@squeek502
Copy link
Owner

Seems like a Modrinth bug, it keeps resetting to "Unsupported" somehow.

@squeek502 squeek502 reopened this Feb 7, 2024
@squeek502
Copy link
Owner

squeek502 commented May 1, 2024

Set both client and server side to required for now since Modrinth seems to only allow certain combinations and 'client required + server optional' doesn't seem to be an allowed combination.

The relevant issue is modrinth/code#2586

EDIT: Actually, re-set it as 'unsupported' on the server-side to avoid the scenario in #275

EDIT#2: On third thought, I think setting client-side and server-side to 'optional' might make the most sense, so I did that.

Will need a fix on Modrinth's end to get this set properly.

@squeek502 squeek502 added the upstream Specific to something that this mod relies on label May 1, 2024
@squeek502 squeek502 changed the title Update Modrinth metadata Modrinth doesn't allow client side: required with server side: optional May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Specific to something that this mod relies on
Projects
None yet
Development

No branches or pull requests

2 participants