Skip to content

Commit

Permalink
Aha! Skip DebuggerTests bc. they simulate a user interrupt which will…
Browse files Browse the repository at this point in the history 
… abort test execution on the CI. Unfortunately, STON has no syntax for comments.
  • Loading branch information
@marceltaeumel
marceltaeumel committed Jun 8, 2022
1 parent f00f0c4 commit 1cfeebe
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions smalltalk-ci/Squeak-6.0.ston
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ SmalltalkCISpec {
#exclude : {
#classes : [
#AllocationTest,
#DebuggerTests,
#LangEnvBugs,
#Win32VMTest
]
Expand Down
1 change: 1 addition & 0 deletions smalltalk-ci/Squeak-trunk.ston
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ SmalltalkCISpec {
#exclude : {
#classes : [
#AllocationTest,
#DebuggerTests,
#LangEnvBugs,
#Win32VMTest
]
Expand Down
1 change: 1 addition & 0 deletions smalltalk-ci/Squeak64-6.0.ston
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ SmalltalkCISpec {
#exclude : {
#classes : [
#AllocationTest,
#DebuggerTests,
#LangEnvBugs,
#Win32VMTest
]
Expand Down
1 change: 1 addition & 0 deletions smalltalk-ci/Squeak64-trunk.ston
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ SmalltalkCISpec {
#exclude : {
#classes : [
#AllocationTest,
#DebuggerTests,
#LangEnvBugs,
#Win32VMTest
]
Expand Down

5 comments on commit 1cfeebe

@LinqLover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, couldn't we adjust the tests instead to work on the CI as well? :(

And haven't the AllocationTests issues been solved in the meantime?

Unfortunately, STON has no syntax for comments.

A hacky solution could be something like:

       #classes : [
         #AllocationTest,
         #DebuggerTests,
+       #'comment: generates user interrupt which would abort test execution',
         #LangEnvBugs,
         #Win32VMTest
       ]

Alternatively, we could teach smalltalkCI to read JSON or YAML files later. 🤓

@marceltaeumel
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A hacky solution could be something like [...]

You would have to also ignore instances of String somewhere else, right? =) Or does this work already? Let's not confuse "hacky solution" with "something only remotely related to an actual solution". ;-)

@LinqLover
Copy link
Contributor

@LinqLover LinqLover commented on 1cfeebe Jun 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #33. :-)

@marceltaeumel
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, couldn't we adjust the tests instead to work on the CI as well? :(

Ehm ... it's tricky enough to support Windows/Linux/Mac. Do you want to increase the effort by having a CI-specific version for each platform?

@LinqLover
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish .smalltalk.ston had support for platform switches. Anyway, let's keep it as is and try to decorate all excluded tests in the future with a comment (as proposed in #33), then we can still address them later if we want.

Please sign in to comment.