Only call setNeedsEnvironmentUpdate() on descendants that have a non-nil ancestor

Author: n8chur

ViewEnvironmentUI/Sources/ViewEnvironmentPropagating.swift

@@ -130,4 +130,16 @@ extension ViewEnvironmentPropagating {
 
         return environment
     }
+
+    @_spi(ViewEnvironmentWiring)
+    public func setNeedsEnvironmentUpdateOnAppropriateDescendants() {
+        for descendant in environmentDescendants {
+            // If the descendant's ancestor is nil it has opted out of environment updates and is likely acting as
+            // a root for propagation bridging purposes (e.g. from a Workflow ViewEnvironment update).
+            // Avoid updating the descendant if this is the case.
+            guard descendant.environmentAncestor != nil else { continue }
+
+            descendant.setNeedsEnvironmentUpdate()
+        }
+    }
 }

ViewEnvironmentUI/Sources/ViewEnvironmentPropagatingObject.swift

@@ -226,7 +226,7 @@ extension ViewEnvironmentPropagatingObject {
             setNeedsApplyEnvironment()
         }
 
-        environmentDescendants.forEach { $0.setNeedsEnvironmentUpdate() }
+        setNeedsEnvironmentUpdateOnAppropriateDescendants()
     }
 
     private var needsUpdateObservers: [NSObject: ViewEnvironmentUpdateObservation] {

ViewEnvironmentUI/Sources/ViewEnvironmentPropagationNode.swift

@@ -58,6 +58,6 @@ public struct ViewEnvironmentPropagationNode: ViewEnvironmentCustomizing {
     }
 
     public func setNeedsEnvironmentUpdate() {
-        environmentDescendants.forEach { $0.setNeedsEnvironmentUpdate() }
+        setNeedsEnvironmentUpdateOnAppropriateDescendants()
     }
 }