Skip to content

Commit 2840d63

Browse files
authored
Merge pull request #116 from square/bcheng/revert-oncreate-changes
Revert onCreate changes
2 parents 93d8fc1 + f161196 commit 2840d63

File tree

4 files changed

+26
-8
lines changed

4 files changed

+26
-8
lines changed

android/src/main/java/com/squareup/sdk/reader/flutter/SquareReaderSdkFlutterPlugin.java

+8-3
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,12 @@ private void initializeReaderSdk() {
157157
return;
158158
}
159159

160-
ReaderSdk.initialize(currentActivity.getApplication());
161-
sdkInitialized = true;
160+
try {
161+
ReaderSdk.initialize(currentActivity.getApplication());
162+
sdkInitialized = true;
163+
} catch (IllegalStateException e) {
164+
// allow double-initialization; devs _should_ init in Application.onCreate,
165+
// but to be non-breaking we try here also in case they didn't.
166+
}
162167
}
163-
}
168+
}

example/android/app/src/main/java/com/example/flutter/squareup/sdk/reader/MainActivity.kt example/android/app/src/main/java/com/example/flutter/squareup/sdk/reader/MainActivity.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@
1515
*/
1616
package com.example.flutter.squareup.sdk.reader;
1717

18-
import io.flutter.embedding.android.FlutterActivity
18+
import androidx.annotation.NonNull;
1919

20-
class MainActivity: FlutterActivity() {
20+
import io.flutter.embedding.android.FlutterActivity;
21+
22+
public class MainActivity extends FlutterActivity {
2123
}
2224

example/android/app/src/main/java/com/example/flutter/squareup/sdk/reader/MainApplication.kt example/android/app/src/main/java/com/example/flutter/squareup/sdk/reader/MainApplication.java

+13-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,18 @@
1515
*/
1616
package com.example.flutter.squareup.sdk.reader;
1717

18-
import io.flutter.app.FlutterApplication
18+
import com.squareup.sdk.reader.ReaderSdk;
19+
import io.flutter.app.FlutterApplication;
1920

20-
class MainApplication: FlutterApplication() {
21+
import io.flutter.view.FlutterMain;
22+
23+
24+
public class MainApplication extends FlutterApplication {
25+
26+
@Override
27+
public void onCreate() {
28+
super.onCreate();
29+
ReaderSdk.initialize(this);
30+
FlutterMain.startInitialization(this);
31+
}
2132
}

pubspec.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: square_reader_sdk
22
description: An open source Flutter plugin for calling Square’s native Reader SDK implementations to take in-person payments on iOS and Android.
3-
version: 4.0.0
3+
version: 4.0.1
44
homepage: https://github.com/square/reader-sdk-flutter-plugin
55

66
environment:

0 commit comments

Comments
 (0)