From 4fbf10bd8d6081553f5eeb9994aafc67ea76e1c7 Mon Sep 17 00:00:00 2001
From: Matthew McPherrin <mmc@squareup.com>
Date: Thu, 5 Dec 2019 20:35:25 -0800
Subject: [PATCH] Unregister metrics when stopping monitoring them

---
 pkg/ds/farm.go | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/pkg/ds/farm.go b/pkg/ds/farm.go
index d56b6b660..302464e8c 100644
--- a/pkg/ds/farm.go
+++ b/pkg/ds/farm.go
@@ -580,6 +580,18 @@ func (dsf *Farm) spawnDaemonSet(
 			for {
 				select {
 				case <-ctx.Done():
+					for _, name := range ds.MetricNames("healthy") {
+						p2metrics.Registry.Unregister(name)
+					}
+					for _, name := range ds.MetricNames("critical") {
+						p2metrics.Registry.Unregister(name)
+					}
+					for _, name := range ds.MetricNames("unknown") {
+						p2metrics.Registry.Unregister(name)
+					}
+					for _, name := range ds.MetricNames("warning") {
+						p2metrics.Registry.Unregister(name)
+					}
 					return
 				case <-ticks.C:
 					eligible, err := ds.EligibleNodes()