Make interactive mode the default

Closes: gh-1186

Signed-off-by: Andrey Litvitski <[email protected]>

Author: therepanic

spring-shell-autoconfigure/src/main/java/org/springframework/shell/boot/ShellRunnerAutoConfiguration.java

@@ -61,15 +61,15 @@ public static class NonePrimaryCommandConfiguration {
 
 		@Bean
 		@ConditionalOnProperty(prefix = "spring.shell.interactive", value = "enabled", havingValue = "true",
-				matchIfMissing = false)
+				matchIfMissing = true)
 		public InteractiveShellRunner interactiveApplicationRunner(LineReader lineReader, PromptProvider promptProvider,
 				Shell shell, ShellContext shellContext) {
 			return new InteractiveShellRunner(lineReader, promptProvider, shell, shellContext);
 		}
 
 		@Bean
 		@ConditionalOnProperty(prefix = "spring.shell.noninteractive", value = "enabled", havingValue = "true",
-				matchIfMissing = true)
+				matchIfMissing = false)
 		public NonInteractiveShellRunner nonInteractiveApplicationRunner(Shell shell, ShellContext shellContext,
 				ObjectProvider<NonInteractiveShellRunnerCustomizer> customizer) {
 			NonInteractiveShellRunner shellRunner = new NonInteractiveShellRunner(shell, shellContext);

spring-shell-autoconfigure/src/test/java/org/springframework/shell/boot/ShellRunnerAutoConfigurationTests.java

@@ -56,8 +56,8 @@ class ShellRunnerAutoConfigurationTests {
 	class Interactive {
 
 		@Test
-		void disabledByDefault() {
-			contextRunner.run(context -> assertThat(context).doesNotHaveBean(InteractiveShellRunner.class));
+		void enabledByDefault() {
+			contextRunner.run(context -> assertThat(context).hasSingleBean(InteractiveShellRunner.class));
 		}
 
 		@Test
@@ -71,21 +71,21 @@ void disabledWhenPropertySet() {
 	@Nested
 	class NonInteractive {
 
-		@Test
-		void enabledByDefault() {
-			contextRunner.run(context -> assertThat(context).hasSingleBean(NonInteractiveShellRunner.class));
-		}
-
 		@Test
 		void primaryCommandNotSet() {
-			contextRunner.run(context -> {
+			contextRunner.withPropertyValues("spring.shell.noninteractive.enabled:true").run(context -> {
 				assertThat(context).hasSingleBean(NonInteractiveShellRunner.class);
 				NonInteractiveShellRunner runner = context.getBean(NonInteractiveShellRunner.class);
 				String command = (String) ReflectionTestUtils.getField(runner, "primaryCommand");
 				assertThat(command).isNull();
 			});
 		}
 
+		@Test
+		void disabledByDefault() {
+			contextRunner.run(context -> assertThat(context).doesNotHaveBean(NonInteractiveShellRunner.class));
+		}
+
 		@Test
 		void disabledWhenPropertySet() {
 			contextRunner.withPropertyValues("spring.shell.noninteractive.enabled:false")
@@ -95,10 +95,12 @@ void disabledWhenPropertySet() {
 		@Test
 		void canBeCustomized() {
 			NonInteractiveShellRunnerCustomizer customizer = mock(NonInteractiveShellRunnerCustomizer.class);
-			contextRunner.withBean(NonInteractiveShellRunnerCustomizer.class, () -> customizer).run(context -> {
-				NonInteractiveShellRunner runner = context.getBean(NonInteractiveShellRunner.class);
-				verify(customizer).customize(runner);
-			});
+			contextRunner.withPropertyValues("spring.shell.noninteractive.enabled:true")
+				.withBean(NonInteractiveShellRunnerCustomizer.class, () -> customizer)
+				.run(context -> {
+					NonInteractiveShellRunner runner = context.getBean(NonInteractiveShellRunner.class);
+					verify(customizer).customize(runner);
+				});
 		}
 
 	}